fix/perf: Do not prefetch the Changelog page when opening the nav menu - #2002
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
marcleblanc2
marked this pull request as ready for review
September 18, 2026 05:38
marcleblanc2
changed the title
valerybugakov
approved these changes
Sep 18, 2026
marcleblanc2
force-pushed
the
marc/fix/header-changelog-prefetch
branch
from
September 18, 2026 05:58
d1990e0 to
84697de
Compare
The Changelog link in the desktop header and mobile navigation was a next/link, so every docs page prefetched the changelog route (about 61 requests and 500 KB per page view in the audit). Render it as a plain anchor, matching the external sidebar links. Found by the docs site audit in https://ampcode.com/threads/T-01a0ae50-f7f0-779c-aa66-3887c9953e33 Amp-Thread-ID: https://ampcode.com/threads/T-01a0aed2-5fbe-7768-85ea-1378bf98f9ff Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/fix/header-changelog-prefetch
branch
from
September 18, 2026 06:01
84697de to
6608bf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Changelog link in the desktop header (
src/components/Layout.tsx) and mobile navigation (src/components/MobileNavigation.tsx) is anext/linktohttps://sourcegraph.com/changelogBecause it is same-origin in production, Next treats it as an app route and prefetches the changelog app
The audit measured 61 extra requests / ~500 KB on every docs page view
Fix
<a>, the same approach fix: do not prefetch external sidebar links #1978 takes for external sidebar linksVerification
On a preview, the Network tab should show no
/changelogchunk requests after loadScreenshot showing prod on the left, preview on the right, when opening the left nav menu, prod has 137 requests, preview has 65
Broken icon in prod in another PR, coming soon
npx tsc --noEmitandpnpm run lintclean (0 errors)Found by the docs site audit in this Amp thread; rebuilt locally in this one.