fix: do not prefetch external sidebar links - #1978
Draft
marcleblanc2 wants to merge 1 commit into
Draft
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
The Pricing and Changelog entries point at https://sourcegraph.com/..., which next/link treats as an app route on our own origin, so every page load prefetched the marketing pricing page (65 KB of HTML). Render those as plain anchors, and stop prependVersion from turning them into /v/<version>/https://... on versioned docs. Amp-Thread-ID: https://ampcode.com/threads/T-01a0ac9d-704f-73fe-8211-1b3e5840969f Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/perf/sidebar-prefetch
branch
from
September 17, 2026 02:32
e46d73d to
32ea28e
Compare
marcleblanc2
force-pushed
the
marc/fix/external-nav-links
branch
from
September 17, 2026 02:32
4c29c24 to
89821fa
Compare
Contributor
|
Contributor
Author
|
From the docs site audit (crawl of all 502 pages). Same root cause, one more instance outside this PR's files: the Changelog link in the desktop header ( |
marcleblanc2
added a commit
that referenced
this pull request
Sep 18, 2026
#2002) ## Problem - The Changelog link in the desktop header (`src/components/Layout.tsx`) and mobile navigation (`src/components/MobileNavigation.tsx`) is a `next/link` to `https://sourcegraph.com/changelog` - Because it is same-origin in production, Next treats it as an app route and prefetches the changelog app - The audit measured 61 extra requests / ~500 KB on **every docs page view** ## Fix - Render both as plain `<a>`, the same approach #1978 takes for external sidebar links ## Verification - On a preview, the Network tab should show no `/changelog` chunk requests after load - Screenshot showing prod on the left, preview on the right, when opening the left nav menu, prod has 137 requests, preview has 65 - Broken icon in prod in another PR, coming soon <img width="2672" height="1521" alt="image" src="https://github.com/user-attachments/assets/4f9a104f-cacc-4ebf-90fa-776da3b83eb1" /> - `npx tsc --noEmit` and `pnpm run lint` clean (0 errors) Found by the docs site audit in [this Amp thread](https://ampcode.com/threads/T-01a0ae50-f7f0-779c-aa66-3887c9953e33); rebuilt locally in [this one](https://ampcode.com/threads/T-01a0aed2-5fbe-7768-85ea-1378bf98f9ff). Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1976 (
marc/perf/sidebar-prefetch); retarget tomainonce that merges.Problem
navigation.tshas Pricing and Changelog entries withhref: 'https://sourcegraph.com/...'.next/linktreats an absolute URL on the current origin as an app route, so every page load prefetched the marketing pricing page (65 KB of HTML in the HAR). On versioned docs,prependVersionalso turns them into/v/<version>/https://sourcegraph.com/pricing.Fix
NavigationLinkrenders a plain<a>for anyhttp(s)://href.prependVersiononly prefixes paths that start with/.Verification
tsc,pnpm lint,pnpm buildclean. On the preview, the Network tab should show no request tosourcegraph.com/pricingon page load, and the Pricing link should still navigate.