Upgrade stripe - #336
Open
AlistairNorman wants to merge 3 commits into
Open
Upgrade stripe#336AlistairNorman wants to merge 3 commits into
AlistairNorman wants to merge 3 commits into
Conversation
AlistairNorman
force-pushed
the
upgrade-stripe
branch
from
September 2, 2026 22:27
777fb3b to
c71a7a1
Compare
Temporarily removing these two endpoints becuase they cause issues when adding this gem to stores that don't use solidus_api. Will look at re-adding them in the future with proper checks for the gem existing so that we don't try to load in controllers that break Zeitwerk autoloading.
It's the oldest modern version of the Stripe API from 2024-2025 when they switched to having named API versions. Gets us closer to the latest version so that we can start supporting modern features from Stripe.
Solidus deprecated the @current_user_roles ivar in favour of the current_user_roles helper.
AlistairNorman
force-pushed
the
upgrade-stripe
branch
from
September 22, 2026 21:07
c71a7a1 to
f751979
Compare
AlistairNorman
marked this pull request as ready for review
September 22, 2026 21:07
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the version of the Stripe gem to '~> 13.0' so that we have access to more modern features of the Stripe API. This is also the newest version we can use that still supports the now deprecated StripeClient#request method that we're using for basically all of our API calls. That method is deprecated in favour a service based call pattern or using StripeClient#raw_request which has a different interface.
The only version with any migration requirements before v13 is v9, which introduced a change to always sending the API version header with requests. None of the parameters or APIs we're using appear to be impacted by that change so it's okay for us to just let it start sending the API version for us. If customers were locked to an older version of the API, they can skill explicitly set the API by setting it in an initializer like so: Stripe.api_version = '2020-08-27'
With the extension on this version, we can slowly migrate our code to the new service based call pattern and eventually upgrade to the latest version of the Stripe gem.
https://github.com/stripe/stripe-ruby/wiki/Migration-guide-for-v13
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: