Bump to Stripe v13 - #332
Closed
adammathys wants to merge 2 commits into
Closed
adammathys wants to merge 2 commits into
adammathys wants to merge 2 commits into
Conversation
It's the oldest modern version of the Stripe API from 2024-2025 when they switched to having named API versions. Gets us closer to the latest version so that we can start supporting modern features from Stripe.
Temporarily removing these two endpoints becuase they cause issues when adding this gem to stores that don't use solidus_api. Will look at re-adding them in the future with proper checks for the gem existing so that we don't try to load in controllers that break Zeitwerk autoloading.
adammathys
force-pushed
the
stripe-v13
branch
from
September 2, 2026 17:02
489784a to
0a4e27c
Compare
Contributor
|
Closing since this work has been combined with #336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the version of the Stripe gem to '~> 13.0' so that we have access to more modern features of the Stripe API. This is also the newest version we can use that still supports the now deprecated
StripeClient#requestmethod that we're using for basically all of our API calls. That method is deprecated in favour a service based call pattern or usingStripeClient#raw_requestwhich has a different interface.The only version with any migration requirements before v13 is v9, which introduced a change to always sending the API version header with requests. None of the parameters or APIs we're using appear to be impacted by that change so it's okay for us to just let it start sending the API version for us. If customers were locked to an older version of the API, they can skill explicitly set the API by setting it in an initializer like so:
Stripe.api_version = '2020-08-27'With the extension on this version, we can slowly migrate our code to the new service based call pattern and eventually upgrade to the latest version of the Stripe gem.
https://github.com/stripe/stripe-ruby/wiki/Migration-guide-for-v13