[solidus_admin] Add product taxon management by benjaminwil · Pull Request #6610 · solidusio/solidus

benjaminwil · 2026-09-12T04:11:48Z

Summary

Replaces #6296.

This pull request implements product taxon management functionality in the product editor. Now, there are two ways to manage taxons:

Adding existing taxons using the taxon multi-select component in the Product organization panel. (This functionality seems to already have existed but is much improved via this pull request.)
Adding new taxons using the Add new category button, which opens up a taxon creation modal dialog form. New taxons can either be created as root taxons or child taxons of existing taxons.

I have co-opted much of this work from the original author. I will assume responsibility for any changes that need to be made as a result of code review.

Checklist

Note that the original author had already marked these checklist items as completed on #6296.

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

I agree that my PR will be published under the same license as Solidus.
I have written a thorough PR description.
I have kept my commits small and atomic.
I have localized any and all user-facing strings that I added to the source code.
I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

codecov · 2026-09-12T04:18:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.35%. Comparing base (0c0f5aa) to head (d9c7d1a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6610      +/-   ##
==========================================
+ Coverage   92.33%   92.35%   +0.02%     
==========================================
  Files        1050     1052       +2     
  Lines       21364    21354      -10     
==========================================
- Hits        19726    19722       -4     
+ Misses       1638     1632       -6

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Delegate option type methods #name, #presentation, #option_values for easier access in the view.

Now that the pull request that replaced the referenced PR has been merged, we no longer need to skip this test.

By default, a selected option has the same text representation as in the options list. This change allows to customize it.

Indentation with an arrow is only useful when showing the list of taxons in the dropdown, we can just show the name of taxon when selected to save space.

Include hidden field to allow emptying categories collection when none selected. Add link and turbo frame for a new category modal. Modal frame targets category select, so on successful request the only part of the form that will be updated is this select field, preserving any other inputs that user might have yet unsaved in the product form. Turbo stream action update will empty the modal essentially closing it.

With turbo frame response only `product_organization_frame` will be targeted for change after successful request, so in order to show flash message we can use turbo stream replace from within the frame to refresh the flashes.

Hides implementation details of the modal "close" and flashes refresh logic, and also allows to reuse it in similar scenarios.

These helpers are related to new admin so it's better to place them in feature_helpers.rb

Choosing empty parent category will create a root taxon and a new taxonomy record under the hood.

These tests were failing due to there being two dialogs in the DOM. We can disambiguate using the heading text of the dialog.

This change more closely mirrors how the working form for product option type IDs works. Feature tests related to adding taxons were failing, and this change resolves the issue.

I have verified that this is still an issue. I have updated the comment so nobody thinks it's stale (because of the reference to Circle CI).

benjaminwil · 2026-09-16T16:36:51Z

I just rebased against the latest main and resolved a merge conflict related to the solidus_admin feature test helpers file.

tvdeyen

I have not verified with the Figma design, but the taxon select looks weirdly off. We have prett_name on Taxon. Either use that or create a TaxonSelect component. We can do this in subsequent PRs, though

tvdeyen · 2026-09-19T07:36:03Z

+
+  def parent_taxon_options
+    @parent_taxon_options ||= Spree::Taxon.order(:lft).pluck(:name, :id, :depth).map do
+      name, id, depth = _1


Why not use Taxon#pretty_name here?

Even if we decide to use a new style for this select I propose to create a dedicated TaxonSelect instead of hiding it in here.

benjaminwil requested a review from a team as a code owner September 12, 2026 04:11

github-actions Bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin labels Sep 12, 2026

github-project-automation Bot added this to Solidus Admin Sep 12, 2026

benjaminwil force-pushed the admin-product-organization--categories branch from e3300a1 to 1c258fb Compare September 12, 2026 04:14

benjaminwil mentioned this pull request Sep 12, 2026

Admin product organization categories #6296

Closed

4 tasks

benjaminwil force-pushed the admin-product-organization--categories branch from 1c258fb to a2dcfb3 Compare September 12, 2026 04:54

benjaminwil marked this pull request as draft September 12, 2026 04:55

github-actions Bot added the changelog:solidus_backend Changes to the solidus_backend gem label Sep 12, 2026

benjaminwil force-pushed the admin-product-organization--categories branch 4 times, most recently from 852c261 to e932dda Compare September 13, 2026 18:51

benjaminwil mentioned this pull request Sep 13, 2026

Save solidus_admin artifacts during Actions workflows #6611

Merged

5 tasks

benjaminwil force-pushed the admin-product-organization--categories branch 15 times, most recently from 4931362 to 4d2e196 Compare September 14, 2026 20:08

benjaminwil force-pushed the admin-product-organization--categories branch from 46f3ad3 to 5573c62 Compare September 14, 2026 21:18

github-actions Bot removed the changelog:solidus_backend Changes to the solidus_backend gem label Sep 14, 2026

benjaminwil force-pushed the admin-product-organization--categories branch 2 times, most recently from 8aaeac6 to 59e1684 Compare September 14, 2026 21:55

benjaminwil marked this pull request as ready for review September 14, 2026 23:18

benjaminwil moved this to Review in Solidus Admin Sep 15, 2026

jarednorman approved these changes Sep 16, 2026

View reviewed changes

chaimann and others added 19 commits September 16, 2026 09:34

Delegate methods

5c07f83

Delegate option type methods #name, #presentation, #option_values for easier access in the view.

Unskip feature test

830bb45

Now that the pull request that replaced the referenced PR has been merged, we no longer need to skip this test.

Add correct label translation

9489151

Create product_taxons resource

0ba9595

Create component for new product category

27a0311

Allow alternative item labels in solidus_select

a707389

By default, a selected option has the same text representation as in the options list. This change allows to customize it.

Change selected items text in taxons select

90132b6

Indentation with an arrow is only useful when showing the list of taxons in the dropdown, we can just show the name of taxon when selected to save space.

Display toasts from turbo frame response

4f756d4

With turbo frame response only `product_organization_frame` will be targeted for change after successful request, so in order to show flash message we can use turbo stream replace from within the frame to refresh the flashes.

Extract frame with stream actions into component

9ad909c

Hides implementation details of the modal "close" and flashes refresh logic, and also allows to reuse it in similar scenarios.

Move capybara feature helpers

4c72c0d

These helpers are related to new admin so it's better to place them in feature_helpers.rb

Add feature tests

15f8455

Add request tests

7b9b972

Fix rubocop offence

13c6dd4

Allow empty parent for new category

cb97676

Choosing empty parent category will create a root taxon and a new taxonomy record under the hood.

Exclude feature_helpers from coverage report

9571cb4

Disambiguate <dialog> in product feature tests

0b33e52

These tests were failing due to there being two dialogs in the DOM. We can disambiguate using the heading text of the dialog.

Fix bug where taxon_ids would not be updated

8cf131c

This change more closely mirrors how the working form for product option type IDs works. Feature tests related to adding taxons were failing, and this change resolves the issue.

Provide latest context re: FIXME in feature test

d9c7d1a

I have verified that this is still an issue. I have updated the comment so nobody thinks it's stale (because of the reference to Circle CI).

benjaminwil force-pushed the admin-product-organization--categories branch from 59e1684 to d9c7d1a Compare September 16, 2026 16:36

jarednorman approved these changes Sep 16, 2026

View reviewed changes

tvdeyen approved these changes Sep 19, 2026

View reviewed changes

Navigation Menu

Uh oh!

[solidus_admin] Add product taxon management - #6610

[solidus_admin] Add product taxon management#6610
benjaminwil wants to merge 19 commits into
solidusio:mainfrom
benjaminwil:admin-product-organization--categories

benjaminwil commented Sep 12, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Sep 12, 2026 •

edited

Loading

Uh oh!

benjaminwil commented Sep 16, 2026

Uh oh!

tvdeyen left a comment

Uh oh!

tvdeyen Sep 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

benjaminwil commented Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

codecov Bot commented Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

benjaminwil commented Sep 16, 2026

Uh oh!

tvdeyen left a comment

Choose a reason for hiding this comment

Uh oh!

tvdeyen Sep 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

benjaminwil commented Sep 12, 2026 •

edited

Loading

codecov Bot commented Sep 12, 2026 •

edited

Loading