Skip to content

Save solidus_admin artifacts during Actions workflows - #6611

Merged
jarednorman merged 1 commit into
solidusio:mainfrom
benjaminwil:github-actions-artifacts
Sep 16, 2026
Merged

jarednorman merged 1 commit into
solidusio:mainfrom
benjaminwil:github-actions-artifacts

Conversation

@benjaminwil

@benjaminwil benjaminwil commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary

It looks like Circle CI had been configured to do this based on the presence of the CIRCLE_ARTIFACTS environment variable. But I found no trace of artifact saving in the GitHub Actions workflow configuration.

I would like to view solidus_admin artifacts if feature tests fail on CI. This commit adds the necessary configuration, in the same style that we enable code coverage reporting per workflow (with a boolean input setting).

Verification

I manually tested that this configuration commit is valid on another pull request, #6610.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

It looks like Circle CI had been configured to do this based on the
presence of the CIRCLE_ARTIFACTS environment variable. But I found no
trace of artifact saving in the GitHub Actions workflow configuration.

I would like to view `solidus_admin` artifacts if feature tests fail on
CI. This commit adds the necessary configuration, in the same style that
we enable code coverage reporting per workflow (with a boolean input
setting).
@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (02f8479) to head (1fc5c39).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6611   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files        1047     1047           
  Lines       21336    21336           
=======================================
  Hits        19694    19694           
  Misses       1642     1642           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjaminwil benjaminwil moved this to Review in Solidus Admin Sep 15, 2026
@jarednorman
jarednorman merged commit 85d7838 into solidusio:main Sep 16, 2026
43 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in Solidus Admin Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants