Skip to content

docs: note that platform colors keep a property on the loop (hold for #10305) - #10355

Closed
MatiPl01 wants to merge 1 commit into
mainfrom
@matipl01/docs-platform-color-routing
Closed

MatiPl01 wants to merge 1 commit into
mainfrom
@matipl01/docs-platform-color-routing

Conversation

@MatiPl01

@MatiPl01 MatiPl01 commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #10328, to land together with platform color support (#10305), not before it.

The routing rules for platform-driven CSS transitions list the table, the callbacks and the iOS easing restriction, but not the shape a color value has to have. Only numeric colors reach the platform: parseValue accepts a color solely when value.isNumber(), and parsePlatformValues returns nothing when either endpoint fails to parse, so a PlatformColor on one end keeps the whole property on the animation loop.

Held as a draft on purpose. CSS does not support platform colors yet, so documenting how they route would describe something users cannot write. Once #10305 lands, this note belongs next to the other routing conditions, and the wording should be re-checked against whatever resolution that PR settles on.

@MatiPl01 MatiPl01 self-assigned this Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 28e084a3-eb3b-4144-b88f-bf799c9c224d

📥 Commits

Reviewing files that changed from the base of the PR and between f41b838 and 3b9da02.

📒 Files selected for processing (1)
  • docs/docs-reanimated/docs/guides/feature-flags.md

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Updated the feature flags guide to document color transition routing. Transitions remain on the animation loop when either endpoint uses PlatformColor or DynamicColorIOS. Platform animation applies only to transitions between plain colors.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description directly explains the documented routing behavior for platform-driven CSS color transitions.
Title check ✅ Passed The title clearly summarizes the documentation change about platform colors remaining on the animation loop.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MatiPl01 MatiPl01 changed the title docs: note that platform colors keep a property on the loop docs: note that platform colors keep a property on the loop (hold for #10305) Aug 20, 2026
@MatiPl01
MatiPl01 marked this pull request as draft August 20, 2026 16:37
@MatiPl01

Copy link
Copy Markdown
Contributor Author

Not worth a standalone docs PR. The note is recorded on #10305 instead, so it lands with platform color support rather than describing something CSS cannot express yet.

@MatiPl01 MatiPl01 closed this Aug 20, 2026
@MatiPl01
MatiPl01 deleted the @matipl01/docs-platform-color-routing branch August 20, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant