[Helper] FileSystem: refactor using std::filesystem#6096
Open
fredroy wants to merge 4 commits into
Open
Conversation
fredroy
added
pr: status to review
The Win32 listDirectory was returning false (no error) when FindFirstFile failed with INVALID_HANDLE_VALUE. This is inconsistent with the Unix codepath (which returns true on opendir failure) and with the documented convention (@return true on error). As a result, findFiles never saw the error and returned 0 instead of -1 on Windows.
fredroy
force-pushed
the
rewrite_filesystem
branch
from
c9f46f1 to
70cf4ff
Compare
Contributor
|
aha I didn't saw this one. I was testing my Qwen setup exactly on the same class... |
Contributor
|
[ci-build][with-all-tests] |
fredroy
removed
the
pr: based on previous PR
bakpaul
reviewed
May 20, 2026
Comment on lines
160
to
176
| bool FileSystem::removeDirectory(const std::string& path) | ||
| { | ||
| #ifdef WIN32 | ||
| if (RemoveDirectory(sofa::helper::widenString(path).c_str()) == 0) | ||
| { | ||
| msg_error("FileSystem::removedirectory()") << path << ": " << Utils::GetLastError(); | ||
| msg_error("FileSystem::removeDirectory()") << path << ": " << Utils::GetLastError(); | ||
| return true; | ||
| } | ||
| #else | ||
| if (rmdir(path.c_str())) | ||
| { | ||
| msg_error("FileSystem::removedirectory()") << path << ": " << strerror(errno); | ||
| msg_error("FileSystem::removeDirectory()") << path << ": " << strerror(errno); | ||
| return true; | ||
| } | ||
| #endif | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Should use std::filesystem::remove_all instead
| return false; | ||
| } | ||
|
|
||
| bool FileSystem::removeAll(const std::string& path){ |
Contributor
There was a problem hiding this comment.
Ok I don't get why adding this instead of modifying the previous one which is meaningless now.
| } | ||
|
|
||
| bool FileSystem::exists(const std::string& path, [[maybe_unused]] bool quiet) | ||
| bool FileSystem::removeFile(const std::string& path) |
Contributor
There was a problem hiding this comment.
Ok so basically it is wrapping all call to std with try catch, do we want that ?
| if ((INT_PTR)ShellExecuteA(nullptr, "open", filename.c_str(), nullptr, nullptr, SW_SHOWNORMAL) > 32) | ||
| success = true; | ||
| #elif defined(__APPLE__) | ||
| pid_t pid; // points to a buffer that is used to return the process ID of the new child process. |
| if (!filename.empty()) | ||
| { | ||
| if (!FileSystem::exists(filename)) | ||
| if (!fs::exists(filename)) |
Contributor
There was a problem hiding this comment.
Why not use the previously created FileSystem::exists ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
Title says all.
computeParentDirectoryandstripDirectoryhave quite different behaviors than their STL counterparts (See the comments) so it still using the previous string-based implementation.Note: different LLM (Qwen) than for the tests (Claude) 🤖 for fairness
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if