Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/maintainers_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,16 @@ Patch and minor updates are auto-approved and auto-merged via the
checking whether the relevant live `docs.slack.dev` page has changed.
- Feature requests for new skills should be discussed in the issue before
implementation begins.
- Labels: `bug` for confirmed issues, `enhancement` for feature requests,
`build` for CI/tooling changes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘οΈβ€πŸ—¨οΈ note: I might continue to use build for some of these changes. Please do feel free to correct me in ongoing changes if something seems odd!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, good catch @zimeg. Commit 4878e01 has updated this section to list all of our labels and how we suggest that are used.

- Labels:
- `bug` β€” confirmed defects
- `enhancement` β€” feature requests and new functionality
- `docs` β€” documentation-only changes
- `test` β€” test-only changes
- `build` β€” CI, GitHub Actions, and build/compilation processes
- `chore` β€” repo structure, required files, release scaffolding, general maintenance
- `dependencies` β€” dependency updates (Dependabot applies this automatically)
- `security` β€” vulnerability fixes, hardening, and security audit findings
(apply alongside `bug`/`build`/`dependencies` as appropriate)

---

Expand Down
10 changes: 8 additions & 2 deletions .github/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,15 @@ changelog:
- title: πŸ€– Build
labels:
- build
- title: πŸ§ͺ Testing/Code Health
- title: πŸ§ͺ Tests
labels:
- code health
- test
- title: 🧹 Chores

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Moved belong Tests because externally developers are impacted by this less.

labels:
- chore
- title: ⬆️ Dependencies
labels:
- dependencies
- title: πŸ”’ Security
labels:
- security
Comment on lines 25 to 27

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ” thought(non-blocking): Following bugs or enhancements with this section might be easiest to follow in updates but I'm most excited for correct labels at this time. Let's save these reorderings for a wide spread follow up?

Expand Down