Skip to content

chore: add build, chore, security labels and align release notes categories#73

Open
mwbrooks wants to merge 4 commits into
mainfrom
mwbrooks-add-chore-label
Open

chore: add build, chore, security labels and align release notes categories#73
mwbrooks wants to merge 4 commits into
mainfrom
mwbrooks-add-chore-label

Conversation

@mwbrooks

@mwbrooks mwbrooks commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

This pull request introduces 3 new labels (chore, build, and security) and fixes the .github/release.yml to not use non-existent labels.

  • Adds a chore label for maintainer task PRs.
    • e.g. repo structure, required files, release scaffolding, general maintenance work - matching the conventional-commit chore: prefix.
  • Adds a build label for changes to compilation and CI processes
    • e.g. build, ci/cd, scripts, etc
  • Adds a security label so security fixes surface distinctly in release notes.
  • Aligns .github/release.yml with the labels that actually exist on the repo.
    • The prior config referenced four non-existent labels (build, code health, docs, security), so those changelog sections silently fell through to "Other changes."
    • The documentation label was renamed to docs to match other slackapi projects.

Preview

  What's Changed

  🚀 Enhancements

  - feat: add /slack:channel-digest command by @WilliamBergamin in #55
  - feat: support --dry-run flag on draft-announcement by @mwbrooks in #82

  🐛 Bug Fixes

  - fix: handle empty channel IDs in summarize-channel gracefully by @mwbrooks in #78
  - fix: correct block-kit validation for section blocks by @WilliamBergamin in #85

  📚 Documentation

  - docs: clarify Ollama setup in AGENTS.md by @WilliamBergamin in #58
  - docs: add screenshots to draft-announcement walkthrough by @mwbrooks in #91

  🤖 Build

  - ci: automate versioning and releases with changesets by @WilliamBergamin in #60
  - ci: publish GitHub Releases from changesets release step by @WilliamBergamin in #71

  🧪 Tests

  - test: add DeepEval coverage for find-discussions by @mwbrooks in #62
  - test: raise ToolCorrectnessMetric threshold to 0.85 by @WilliamBergamin in #88

  🧹 Chores

  - chore: add slack-skills-plugin-team as default CODEOWNERS team by @mwbrooks in #63
  - chore: add pull request template by @mwbrooks in #69
  - chore: add chore + security labels and align release notes categories by @mwbrooks in #73 ← this PR

  ⬆️ Dependencies

  - chore(deps): bump actions/checkout from 6.0.3 to 7.0.0 by @dependabot in #64
  - chore(deps): bump actions/setup-python from 6.2.0 to 6.3.0 by @dependabot in #67

  🔒 Security

  - fix: patch prompt-injection in canvas rendering pipeline by @mwbrooks in #98
  - chore(deps): bump requests from 2.31.0 to 2.32.4 (CVE-2024-XXXXX) by @dependabot in #99

  📦 Other changes

  (empty when every merged PR carries at least one recognized label — which is the goal)

  Full Changelog: https://github.com/slackapi/slack-mcp-plugin/compare/v0.4.0...v0.5.0

Testing

  • This PR itself uses the chore label, serving as the first live test of the new label + release-notes category.

Notes

  • No changeset needed - updates to CI/repo metadata don't affect plugin consumers (per maintainers_guide.md).

Requirements

Introduce a `chore` label for maintainer PRs (CI, build tooling, release
scaffolding, repo files) matching the conventional-commit `chore:` prefix
already in use, plus a `security` label for vulnerability fixes and hardening.

Rework `.github/release.yml` to match the labels that actually exist on the
repo — the prior config referenced non-existent `build`, `code health`,
`docs`, and `security` labels, so those changelog sections silently fell
through to "Other changes". Also splits `dependencies` into its own section
so Dependabot PRs don't drown out real chores.
@mwbrooks mwbrooks added chore Maintainer work: repo files, release scaffolding, general maintenance semver:patch Changes trigger a patch version bump labels Jul 2, 2026
@mwbrooks mwbrooks self-assigned this Jul 2, 2026
Comment thread .github/release.yml Outdated
labels:
- docs
- title: 🤖 Build
- documentation

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: This was pointing to the wrong label name.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 note: IIRC docs is matched across most projects. I'm tempted to suggest it's used here too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can fix this label if we've been using docs consistently!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zimeg Commit 8b6f2ed updates to docs and I've updated the label itself to label:docs as well.

Restores the Security category to its prior slot near the bottom of
the changelog category list.
Comment thread .github/release.yml
- build
- title: 🧪 Testing/Code Health
- test
- title: 🧹 Chores

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Moved belong Tests because externally developers are impacted by this less.

@mwbrooks mwbrooks marked this pull request as ready for review July 2, 2026 23:14
@mwbrooks mwbrooks requested a review from a team as a code owner July 2, 2026 23:14

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔏 Quick comment but I like these changes @mwbrooks!

Comment thread .github/release.yml Outdated
labels:
- docs
- title: 🤖 Build
- documentation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 note: IIRC docs is matched across most projects. I'm tempted to suggest it's used here too?

mwbrooks added 2 commits July 2, 2026 16:37
Match the shorter `docs` form used across other slackapi projects.
The GitHub label itself was renamed in place (preserves existing PR/issue
associations); this updates the `.github/release.yml` reference to match.
Match slack-cli's `build` label ("Changes to compilation and CI processes",
color #615196) for CI and build-tooling PRs. Narrows the `chore` scope to
repo files, release scaffolding, and general maintenance.
@mwbrooks mwbrooks changed the title chore: add chore + security labels and align release notes categories chore: add build, chore, security labels and align release notes categories Jul 3, 2026

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks Great positioning for maintenance ongoing! Please feel free to merge this. I'm looking forward to sharing this change as needed with adjacent projects.

Comment thread .github/release.yml
Comment on lines 25 to 27
- title: 🔒 Security
labels:
- security

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔏 thought(non-blocking): Following bugs or enhancements with this section might be easiest to follow in updates but I'm most excited for correct labels at this time. Let's save these reorderings for a wide spread follow up?

- Feature requests for new skills should be discussed in the issue before
implementation begins.
- Labels: `bug` for confirmed issues, `enhancement` for feature requests,
`build` for CI/tooling changes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ note: I might continue to use build for some of these changes. Please do feel free to correct me in ongoing changes if something seems odd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintainer work: repo files, release scaffolding, general maintenance semver:patch Changes trigger a patch version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants