feat: migrate task type taxonomy#122
Conversation
- **Remove** retired Boundary and Entity Relation fixtures from the active catalog - **Rename** sequence fixtures to the current taxonomy and fix entity offsets Co-Authored-By: OpenAI Codex GPT-5 <noreply@openai.com>
- **Replace** legacy sequence output keys with the current Entity Recognition, Relation Identification, and Sequence Tagging keys - **Remove** retired Entity Relation and Boundary options from task creation - **Add** regression coverage for registry keys, previews, names, and entity fixture offsets Co-Authored-By: OpenAI Codex GPT-5 <noreply@openai.com>
- **Remove** retired output type configurations from the active examples - **Rename** sequence configurations and dependency references to the current keys Co-Authored-By: OpenAI Codex GPT-5 <noreply@openai.com>
- **Update** the taxonomy, architecture decision, and task creation specification for eight active output types - **Document** breaking config key migrations and synchronize the visual overview and status index Co-Authored-By: OpenAI Codex GPT-5 <noreply@openai.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Summary
I've completed a thorough review of this PR which adds taxonomy cascading functionality to task creation. The changes include implementation files, comprehensive test coverage, architecture documentation, configuration files, and detailed specifications.
Key Changes Reviewed:
- Task creation HTML with Alpine.js implementation for taxonomy cascading
- Playwright test suite with comprehensive coverage
- Architecture Decision Record for output type composition
- ABSA-VA task configuration
- Detailed specification documentation
Assessment:
All code changes appear functionally correct with no critical defects identified. The implementation includes proper event handling, state management, and user interaction flows. Test coverage is comprehensive and well-structured.
No blocking issues found. The PR is ready for merge from a code quality perspective.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
- **Replace** the eight Object.hasOwn registry checks in task-new-taxonomy-cascade.spec.ts with the `in` operator because the prototype tsconfig lib targets ES2020, where ObjectConstructor lacks hasOwn (TS2550) and the Prototype Type Check CI job fails - **Keep** tsconfig untouched: bumping lib to ES2022 is a config-wide change outside this PR's single taxonomy-migration purpose Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 participant
Purpose
Migrate the task type taxonomy to its final naming and composition: rename three output types, retire two, and align every artifact (spec, ADR, functional map, prototype, visual overview, task configs, example data, tests) to the same 8-key registry.
Reason
The old taxonomy mixed implementation-flavored names (
span,token_class,relation_triple) with two types (boundary,entity_relation) that ADR-029's composition model made redundant — their use cases are now expressed by composing the remaining output types (e.g.entity_recognition+relation_identification). Keeping stale keys in configs and docs risked divergence between spec 013 and the prototype.Result
spanentity_recognitiontoken_classsequence_taggingrelation_triplerelation_identificationboundaryentity_relationentity_recognition+relation_identificationcompositionC(8,2) + 8 = 36pairwise combinations).OUTPUT_TYPE_REGISTRYexposes exactly the 8 new keys; composite configs (absa-va,medical-ner-re) re-expressed with the new names.task-new-taxonomy-cascade.spec.tsguards the cascade (category → input type → output type) and asserts retired keys stay absent.Changed Files
specs/task-management/013-task-new/spec.mdspecs/STATUS.mddocs/adr/029-output-type-composition.mddocs/product/functional-map/task-type-taxonomy.mddocs/product/task-configs/*(7 files)span/token-class/relation-tripleconfigs; removedboundary,entity-relation; composite configs updateddocs/product/example-data/*(5 files)design/prototype/pages/task-management/task-new.htmldocs/product/visual-overview/task-new-output-types.htmldesign/prototype/tests/task-management/*.spec.ts(3 files)Test Plan
npx playwright teston the 3 changed spec files — 22/22 passedNotes
spec-ready(not archived), consistent with its ongoing status.Impact Scope
Related
None
🤖 Generated with Claude Code