docs: align local verification commands with CI jobs#123
Conversation
- **Add** prototype typecheck + playwright commands to CLAUDE.md Verification Commands and pr-flow Step 3 because the Prototype CI jobs had no local counterpart, so an ES2020/ES2022 tsc error on PR #122 was first caught in CI instead of before push - **State** the alignment rule explicitly: every CI job must have a matching local command, added in the same PR that adds the job Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
Documentation changes correctly implement the stated purpose: aligning local verification commands with CI jobs. Both files now include prototype testing commands (pnpm typecheck and pnpm playwright test) with proper context indicating when to run them. The new alignment rule in CLAUDE.md ensures this pattern is followed for future CI additions. No blocking issues found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Purpose
Make the local verification command list cover every CI job so type/test failures surface before push, not in CI.
Reason
PR #122 failed the "Prototype — Type Check (tsc)" CI job on an error (
Object.hasOwnvslib: ES2020) that no local command could have caught: CLAUDE.md Verification Commands and pr-flow Step 3 listed backend and frontend checks only —design/prototypehad CI jobs (typecheck, Playwright) with no local counterpart.Result
pnpm typecheck,pnpm playwright test, run whendesign/prototype/**changed) and states the alignment rule: every CI job must have a matching local command, added in the same PR that adds the job.Changed Files
CLAUDE.md.claude/commands/pr-flow.mdTest Plan
pnpm typecheckandnpx playwright testwere executed indesign/prototype/on PR feat: migrate task type taxonomy #122 todayImpact Scope
Related
#122 (incident that motivated this)
🤖 Generated with Claude Code