fix(operator): key a pool's allowed-node label on its UUID - #505
Merged
Merged
Conversation
boddumanohar
force-pushed
the
fix/pool-node-label-63-byte-limit
branch
2 times, most recently
from
September 9, 2026 09:25
1d00f8f to
f11499d
Compare
boddumanohar
force-pushed
the
fix/pool-node-label-63-byte-limit
branch
from
September 9, 2026 09:31
f11499d to
6d1ea91
Compare
noctarius
force-pushed
the
main
branch
2 times, most recently
from
September 9, 2026 10:21
60dceb7 to
fbaabe4
Compare
noctarius
approved these changes
Sep 9, 2026
geoffrey1330
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pool's allowed-node label key was built from the namespace, the cluster name, and the pool name, which can exceed the 63 bytes a label name allows. This is causing e2e test to fail.
The API server refused the key, so the allowed node was never labeled and the pool could not be deleted either, since the deletion path writes the same label. It failed the nightly GCP e2e (
SPDKCSI-DHCHAP).The key is now
storage.simplyblock.io/pool.<pool UUID>— 41 bytes whatever anything is named. The derivation and its two constants move toatlas-lib/kube, and the CSI driver and the e2e spec use them instead of their own copies.