fix(operator): name the pool node label storage-pool, matching the kind - #507
Merged
Merged
Conversation
The label identifying a StoragePool on its allowed nodes was storage.simplyblock.io/pool.<uuid>. Spell the segment the way the kind is spelled. The key stays a fixed 41 bytes either way, well inside the 63 a label name may have, so nothing about the length is at stake. Both consumers read the prefix from this constant, so the change is one line of code plus the four places the design documents name the key. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
geoffrey1330
approved these changes
Sep 9, 2026
noctarius
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #505. The label identifying a
StoragePoolon its allowed nodes goes fromstorage.simplyblock.io/pool.<uuid>tostorage.simplyblock.io/storage-pool.<uuid>, spelling the segment the way the kind is spelled.Fixed length either way, since it keys off the UUID — nothing about the limit is at stake. Also accepted by a real API server (server-side dry-run on a live cluster).
One line of code: both consumers read the prefix from
kube.LabelPoolPrefix, so the CSI node plugin's scan and the CSI controller's match follow on their own. The other four lines are the places the design documents name the key.🤖 Generated with Claude Code