Skip to content

[claude][vibe] Remove unused SetComplexFormComponentChange #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myieye merged 1 commit into from
Jul 22, 2026
Merged

[claude][vibe] Remove unused SetComplexFormComponentChange #2462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions backend/FwLite/LcmCrdt.Tests/Changes/ChangeDeserializationRegressionData.latest.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,27 +890,6 @@
"Order": 0.1655437666547228,
"EntityId": "e92d4673-888c-3204-0767-17adc2a2405e"
},
{
"$type": "SetComplexFormComponentChange",
"ComplexFormEntryId": "bf296463-7b81-4a33-b9e7-6f4f8179715e",
"ComponentEntryId": null,
"ComponentSenseId": null,
"EntityId": "d5c89801-cedc-403e-9ed6-f734ad0ddf23"
},
{
"$type": "SetComplexFormComponentChange",
"ComplexFormEntryId": null,
"ComponentEntryId": "470eb4a9-50d7-4c28-93b2-019b1e5cf9d6",
"ComponentSenseId": null,
"EntityId": "beaa8382-2b49-45a5-81eb-e5825004fb98"
},
{
"$type": "SetComplexFormComponentChange",
"ComplexFormEntryId": null,
"ComponentEntryId": "e0d469cd-9d2f-44f5-8147-102f683c18ed",
"ComponentSenseId": "7a1c054f-472a-473f-afed-16f75fe9a90f",
"EntityId": "01b98e0e-c95f-430d-9512-9db44fdf7b2a"
},
{
"$type": "jsonPatch:Publication",
"PatchDocument": [],
Expand Down
10 changes: 0 additions & 10 deletions backend/FwLite/LcmCrdt.Tests/Changes/ChangeSerializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
using System.Text.Json;
using System.Text.Json.Nodes;
using FluentAssertions.Execution;
using LcmCrdt.Changes.Entries;
using LcmCrdt.Tests.Data;
using SIL.Harmony.Changes;

Expand All @@ -12,15 +11,6 @@ public class ChangeSerializationTests : BaseSerializationTest
{
private static IEnumerable<IChange> GeneratedChangesForType(Type type)
{
//can't generate this type because there's no public constructor
if (type == typeof(SetComplexFormComponentChange))
{
yield return SetComplexFormComponentChange.NewComplexForm(Guid.NewGuid(), Guid.NewGuid());
yield return SetComplexFormComponentChange.NewComponent(Guid.NewGuid(), Guid.NewGuid());
yield return SetComplexFormComponentChange.NewComponentSense(Guid.NewGuid(), Guid.NewGuid(), Guid.NewGuid());
yield break;
}

object change;
try
{
Expand Down
3 changes: 0 additions & 3 deletions backend/FwLite/LcmCrdt.Tests/Changes/UseChangesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,6 @@ private static IEnumerable<ChangeWithDependencies> GetAllChanges()
var createcomponentEntryChange = new CreateEntryChange(componentEntry);
yield return new ChangeWithDependencies(createcomponentEntryChange);

var setComplexFormComponentChange = SetComplexFormComponentChange.NewComponent(complexFormComponent.Id, componentEntry.Id);
yield return new ChangeWithDependencies(setComplexFormComponentChange, [createcomponentEntryChange, createComplexFormComponentChange]);

var setSenseOrderChange = new LcmCrdt.Changes.SetOrderChange<Sense>(sense.Id, 10);
yield return new ChangeWithDependencies(setSenseOrderChange, [createSenseChange]);

Expand Down
4 changes: 0 additions & 4 deletions backend/FwLite/LcmCrdt.Tests/DataModelSnapshotTests.VerifyChangeModels.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,6 @@
DerivedType: ReplacePublicationChange,
TypeDiscriminator: ReplacePublicationChange
},
{
DerivedType: SetComplexFormComponentChange,
TypeDiscriminator: SetComplexFormComponentChange
},
{
DerivedType: AddTranslationChange,
TypeDiscriminator: AddTranslationChange
Expand Down
47 changes: 0 additions & 47 deletions backend/FwLite/LcmCrdt/Changes/Entries/SetComplexFormComponentChange.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion backend/FwLite/LcmCrdt/LcmCrdtKernel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,6 @@ public static void ConfigureCrdt(CrdtConfig config, bool addRemoteResourceEntity
.Add<AddPublicationChange>()
.Add<RemovePublicationChange>()
.Add<ReplacePublicationChange>()
.Add<SetComplexFormComponentChange>()
.Add<CreateComplexFormType>()
.Add<CreateCustomViewChange>()
.Add<EditCustomViewChange>()
Expand Down
Loading