[claude][vibe] Remove unused SetComplexFormComponentChange

[myieye]

[Claude-drafted]

SetComplexFormComponentChange hasn't been created by any code path since #1816 (complex-form components go through AddEntryComponentChange now). Removing it drops a chunk of change-application logic plus its registration and test fixtures.

Verified unused in prod — no CrdtCommits reference the type:

SELECT p."Code", count(*) AS num_changes
FROM "CrdtCommits" c
JOIN "Projects" p ON p."Id" = c."ProjectId"
CROSS JOIN LATERAL jsonb_array_elements(c."ChangeEntities") AS ce
WHERE ce->'Change'->>'$type' = 'SetComplexFormComponentChange'
GROUP BY p."Code";
-- 0 rows (sanity-checked: this query does return rows for change types that are present)

Text-match variant — also catches the legacy string-encoded Change form

SELECT p."Code", c."ProjectId", count(*) AS commits_with_change
FROM "CrdtCommits" c
JOIN "Projects" p ON p."Id" = c."ProjectId"
WHERE c."ChangeEntities"::text LIKE '%SetComplexFormComponentChange%'
GROUP BY p."Code", c."ProjectId";

Heads up for review: retiring a polymorphic change type means deleting its samples from the change regression fixtures — they can't move to the legacy file, they'd fail to deserialize once the $type is unregistered — so this bends the "never remove" note in those files.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 85a0bfb2-56ae-435e-b289-0ce2f6f8737d

📥 Commits

Reviewing files that changed from the base of the PR and between bd2c823 and 9c037eb.

📒 Files selected for processing (6)

• backend/FwLite/LcmCrdt.Tests/Changes/ChangeDeserializationRegressionData.latest.verified.txt
• backend/FwLite/LcmCrdt.Tests/Changes/ChangeSerializationTests.cs
• backend/FwLite/LcmCrdt.Tests/Changes/UseChangesTests.cs
• backend/FwLite/LcmCrdt.Tests/DataModelSnapshotTests.VerifyChangeModels.verified.txt
• backend/FwLite/LcmCrdt/Changes/Entries/SetComplexFormComponentChange.cs
• backend/FwLite/LcmCrdt/LcmCrdtKernel.cs

💤 Files with no reviewable changes (6)

• backend/FwLite/LcmCrdt.Tests/Changes/UseChangesTests.cs
• backend/FwLite/LcmCrdt/Changes/Entries/SetComplexFormComponentChange.cs
• backend/FwLite/LcmCrdt.Tests/DataModelSnapshotTests.VerifyChangeModels.verified.txt
• backend/FwLite/LcmCrdt.Tests/Changes/ChangeSerializationTests.cs
• backend/FwLite/LcmCrdt/LcmCrdtKernel.cs
• backend/FwLite/LcmCrdt.Tests/Changes/ChangeDeserializationRegressionData.latest.verified.txt

---

📝 Walkthrough

Walkthrough

The obsolete SetComplexFormComponentChange implementation and registrations are removed. Related serialization, usage, snapshot, and deserialization regression data are updated, while ConfigureCrdt registers additional change types.

Changes

CRDT change registration and validation

Layer / File(s)	Summary
Update CRDT change registration backend/FwLite/LcmCrdt/LcmCrdtKernel.cs	Removes SetComplexFormComponentChange from ConfigureCrdt and adds complex-form, custom-view, comment, morph-type, and ordering change registrations.
Remove obsolete change coverage backend/FwLite/LcmCrdt/Changes/Entries/SetComplexFormComponentChange.cs, backend/FwLite/LcmCrdt.Tests/Changes/*, backend/FwLite/LcmCrdt.Tests/DataModelSnapshotTests.VerifyChangeModels.verified.txt	Deletes the change implementation and removes its generated instances, snapshot entry, and regression records.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• sillsdev/languageforge-lexbox#2382: Also changes the CRDT change-type registration list in LcmCrdtKernel.cs.

Poem

A bunny hops through changes bright,
No complex-form entry in sight.
New types join the CRDT queue,
Test snapshots match the view.
Thump, thump—clean data blooms!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: removing the unused SetComplexFormComponentChange type.
Description check	✅ Passed	The description is directly related to the changeset and explains why the type, fixtures, and registration were removed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/setcomplexformcomponentchange-review-af7fab

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Jul 21, 2026, 4:00 PM
e2e (Inspect)	✅ No changes detected	-	Jul 21, 2026, 4:08 PM

[hahn-kev]

scary