Fix focus handling when opening the morpheme editor - #178
Conversation
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughChangesMorpheme editor interactions now use pointer-specific outside dismissal and portal-timed auto-focus. Gloss inputs report focus through Morpheme focus flow
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant TokenChip
participant MorphemeBox
participant MorphemeGlossInput
TokenChip->>MorphemeBox: open editor with onGlossFocus
MorphemeBox->>MorphemeGlossInput: pass onFocus callback
MorphemeGlossInput->>TokenChip: report gloss focus
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 8 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).
Opening the editor now focuses its token and its own input: the morpheme cells no longer let the chip label steal focus, and the panel relies on the popover's open auto-focus, which a mount effect could never do since the portal has no children on that commit.
0048e54 to
9d1bf8c
Compare
Opening the editor now focuses its token and its own input: the morpheme cells no longer let the chip label steal focus, and the panel relies on the popover's open auto-focus, which a mount effect could never do since the portal has no children on that commit.
This change is
Summary by CodeRabbit
Bug Fixes
Tests