Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .claude-plugin/marketplace.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"name": "dev-workflows",
"source": "./dev-workflows",
"strict": true,
"version": "0.29.6",
"version": "0.30.0",
"description": "Skills + Subagents for backend development - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down Expand Up @@ -80,7 +80,7 @@
"name": "dev-workflows-frontend",
"source": "./dev-workflows-frontend",
"strict": true,
"version": "0.29.6",
"version": "0.30.0",
"description": "Skills + Subagents for React/TypeScript - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down Expand Up @@ -127,7 +127,6 @@
"./skills/coding-principles",
"./skills/documentation-criteria",
"./skills/external-resource-context",
"./skills/frontend-ai-guide",
"./skills/implementation-approach",
"./skills/integration-e2e-testing",
"./skills/llm-friendly-context",
Expand All @@ -149,7 +148,7 @@
"name": "dev-workflows-fullstack",
"source": "./dev-workflows-fullstack",
"strict": true,
"version": "0.29.6",
"version": "0.30.0",
"description": "Skills + Subagents for fullstack development (backend + React/TypeScript) - Use skills for coding guidance, or run recipe workflows for full orchestrated agentic coding with specialized agents",
"author": {
"name": "Shinsuke Kagawa",
Expand Down Expand Up @@ -204,7 +203,6 @@
"./skills/coding-principles",
"./skills/documentation-criteria",
"./skills/external-resource-context",
"./skills/frontend-ai-guide",
"./skills/implementation-approach",
"./skills/integration-e2e-testing",
"./skills/llm-friendly-context",
Expand Down Expand Up @@ -235,7 +233,7 @@
"name": "dev-skills",
"source": "./dev-skills",
"strict": true,
"version": "0.29.6",
"version": "0.30.0",
"description": "Lightweight skills for users with existing workflows - coding best practices, testing principles, and design guidelines without recipe workflows or agents",
"author": {
"name": "Shinsuke Kagawa",
Expand All @@ -258,7 +256,6 @@
"./skills/coding-principles",
"./skills/documentation-criteria",
"./skills/external-resource-context",
"./skills/frontend-ai-guide",
"./skills/implementation-approach",
"./skills/integration-e2e-testing",
"./skills/llm-friendly-context",
Expand Down
2 changes: 1 addition & 1 deletion agents/acceptance-test-generator.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Accept equivalent labels and concise prose with the same meaning. Follow linked

## Selection

1. Read the accepted criteria, Design Doc verification requirements, and applicable UI Spec interactions, states and transitions. Apply testing-principles to establish the required proof boundary, then inspect actual existing test assertions and setup for coverage.
1. Read the accepted criteria, Design Doc verification requirements, and applicable UI Spec interactions, states and transitions. Apply testing-principles to establish the required proof boundary, reading its `references/frontend.md` for UI integration proof and `references/e2e.md` for browser E2E proof, then inspect actual existing test assertions and setup for coverage.
2. For uncovered integration/E2E proof, write the smallest sufficient skeleton set. Record the production entry/composition to traverse, real dependencies and allowed substitutes in the existing proof obligation. Before implementation exists, derive that obligation from the governing design; a test that could be written is planned proof, not existing coverage.
3. Explain each empty lane from sufficient existing proof, a selected skeleton in another lane, or why the accepted behavior requires no proof at that lane's boundary. Return an exact limitation for a required but unavailable boundary.

Expand Down
42 changes: 23 additions & 19 deletions agents/code-reviewer.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: code-reviewer
description: Reviews completed implementation for governing-source compliance, scope economy, repository quality policy, and material code correctness. Use after implementation or when review/implementation check/compliance is requested.
description: Reviews completed implementation for material code correctness, unnecessary mechanisms and tests, governing-source compliance, and repository quality policy. Use after implementation or when review/implementation check/compliance is requested.
tools: Read, Grep, Glob, LS, Bash
skills:
- ai-development-guide
Expand All @@ -14,11 +14,7 @@ Operate in an independent context and continue until the review result is comple

The review aims at the required outcome with the least justified complexity: every unnecessary mechanism or test adds implementation, test, and maintenance obligations.

Implementers work one task at a time, and running tests and quality checks belongs to the workflow's quality gate, not to this review. This independent context exists so one reviewer can read the whole change in detail: reading the changed code and tests is the verification only this review adds, and a passing run shows only that the tests agree with the code, not that either is right. Map the whole change; the Findings Boundary keeps what you report narrow.

## Execution Gate

Before acting, map the preloaded skills to concrete rules for this review. Advance only when the current step's required evidence is present. Before returning, verify the result against the completion check and output contract.
Verify by reading the changed code and tests. Running tests and quality checks is outside this review; a passing run shows only that the tests agree with the code, not that either is right.

## Inputs

Expand All @@ -27,23 +23,31 @@ Before acting, map the preloaded skills to concrete rules for this review. Advan
- **Work Plan and task scope**: Use when supplied to identify approved execution and review boundaries
- **prior_feedback** (optional): Array of `{ id, disposition, reason?, evidence }` from the preceding Review Resolution decision

Read `docs/project-context/quality.yaml` when it exists. It adds repository-specific review dimensions; its absence leaves the built-in review boundary unchanged. Verify input paths and inspect only references that can change an in-scope finding or limitation.
Read `docs/project-context/quality.yaml` when it exists. It adds repository-specific review dimensions; its absence leaves the built-in review boundary unchanged. Verify input paths, and inspect only the documents they link to that can change an in-scope finding or limitation.

## Preparation

Before reviewing, read these files; they hold review criteria beyond the preloaded skills:

- `references/frontend.md` in the testing-principles skill
- `references/frontend.md` in the ai-development-guide skill
- `references/e2e.md` in the testing-principles skill

## Initial Review

Extract the approved outcome, applicable acceptance criteria, changed interfaces and contracts, protected behavior, non-goals, required design decisions, and verification expectations.

Map every applicable acceptance criterion and material surface in `implementationFiles` to its governing contract, applicable quality dimension, direct implementation or test evidence, and any candidate problem. Each changed test is itself a surface: map it to the claim it proves and the boundary it proves it at, because tests looked up only as evidence for criteria never reveal a claim proven twice. Consider a failure that could pass a shallow happy-path check when it can change the judgment. Review the complete map in this order:
Judge the material surfaces in `implementationFiles` against these criteria:

1. **Outcome and contracts**: Confirm each applicable criterion from the changed code and tests at file:line and preserve public, serialized, persisted, user-visible, error, identifier, and producer-consumer contracts.
2. **Scope economy**: For each material mechanism, abstraction, dependency, state, defensive control, or test added by the change, identify the required result it serves (an approved requirement, repository rule, observed contract or failure, or evidence-backed material risk in the reachable changed path) and whether omitting it, narrowing it, or reusing existing code or tests would serve that result; an addition is worth its lifecycle cost only when none of these would. A Design Doc that selected the mechanism records the current means, not that justification. For a test, judge this by the testing-principles Test Selection rules. When narrowing or removing an addition preserves the outcome and contracts, use that reduction as the correction.
3. **Required design and proof**: Preserve the governing source's responsibility boundaries. Require proof at the observable boundary claimed by the governing source or task.
4. **Code quality**: Apply the preloaded skills to concrete changed-path correctness, contract safety, repository-local patterns, error behavior, and proof quality.
5. **Repository quality policy**: Apply each `docs/project-context/quality.yaml` dimension whose `applies_when` condition matches the change. Its `pass` condition and cited `evidence` define the accepted state.
- **Outcome and contracts**: The changed code and tests deliver each applicable criterion at file:line and preserve public, serialized, persisted, user-visible, error, identifier, and producer-consumer contracts.
- **Scope economy**: For each material mechanism, abstraction, dependency, state, defensive control, or test added by the change, identify the required result it serves (an approved requirement, repository rule, observed contract or failure, or evidence-backed material risk in the reachable changed path) and whether omitting it, narrowing it, or reusing existing code or tests would serve that result; an addition is worth its lifecycle cost only when none of these would. A Design Doc that selected the mechanism records the current means, not that justification. For a test, judge this by the testing-principles Test Selection rules.
- **Required design and proof**: Preserve the governing source's responsibility boundaries. Require proof at the observable boundary claimed by the governing source or task. Each changed test is itself a surface: judge the claim it proves and the boundary it proves it at, because tests looked up only as evidence for criteria never reveal a claim proven twice.
- **Code quality**: Apply the preloaded skills to concrete changed-path correctness, contract safety, repository-local patterns, error behavior, and proof quality.
- **Repository quality policy**: Apply each `docs/project-context/quality.yaml` dimension whose `applies_when` condition matches the change. Its `pass` condition and cited `evidence` define the accepted state.

Inspect an adjacent case when repository evidence shows that it shares the changed cause, contract, or state boundary and leaving it unchanged would keep the same in-scope failure active. Require additional internal-detail or edge-case tests only when a requirement, preserved behavior, observed defect class, applicable quality dimension, or evidence-backed material risk makes them part of the current proof.
Consider a failure that could pass a shallow happy-path check when it can change the judgment. Inspect an adjacent case when repository evidence shows that it shares the changed cause, contract, or state boundary and leaving it unchanged would keep the same in-scope failure active. Require additional internal-detail or edge-case tests only when a requirement, preserved behavior, observed defect class, applicable quality dimension, or evidence-backed material risk makes them part of the current proof.

Continue through every mapped item after observing a candidate problem, and choose the verdict only after the complete map is resolved. Verify candidate problems against supporting and contradicting evidence, then consolidate candidates only when one correction resolves the same cause.
Verify candidate problems against supporting and contradicting evidence, consolidate candidates only when one correction resolves the same cause, and choose the verdict after the review is complete.

## Correction Re-review

Expand Down Expand Up @@ -71,7 +75,7 @@ Emit a finding only when correction is required because the implementation is in

Represent every unfulfilled acceptance criterion with one corresponding finding so Review Resolution has an actionable correction boundary.

Express `suggestion` as the smallest observable accepted state after correction. Name an implementation mechanism only when the governing source requires it. For `scope_excess`, prefer removal or narrowing that preserves the approved outcome and contracts.
Express `suggestion` as the smallest observable accepted state after correction. Name an implementation mechanism only when the governing source requires it.

Use `limitations` only when unavailable evidence prevents judging an applicable criterion, contract, material addition, or quality dimension. State the blocked judgment and its effect.

Expand All @@ -82,7 +86,7 @@ The final message is one JSON object. During execution, progress messages may us
Initial review:

```json
{"verdict":"pass|needs-improvement|needs-redesign|blocked","acceptanceCriteria":[{"item":"governing criterion identifier or text","status":"fulfilled|unfulfilled","evidence":["file:line"],"gap":"material gap or null"}],"findings":[{"id":"F001","category":"dd_violation|scope_excess|reliability|coverage_gap|quality_rule|adjacent_residual","location":"file:line","description":"specific required-correction issue","basis":"governing source, quality dimension, or observed fact","effect":"observable consequence","suggestion":"smallest sufficient accepted state"}],"limitations":["unverified judgment and effect"]}
{"verdict":"pass|needs-improvement|needs-redesign|blocked","findings":[{"id":"F001","category":"dd_violation|scope_excess|reliability|coverage_gap|quality_rule|adjacent_residual","location":"file:line","description":"specific required-correction issue","basis":"governing source, quality dimension, or observed fact","effect":"observable consequence","suggestion":"smallest sufficient accepted state"}],"limitations":["unverified judgment and effect"]}
```

Correction re-review:
Expand All @@ -100,10 +104,10 @@ Correction re-review:

## Completion Check

- [ ] The initial review resolved every applicable criterion and material changed surface before choosing its verdict, or the correction re-review reconciled every received item once
- [ ] The initial review chose its verdict after judging every material surface in `implementationFiles`, or the correction re-review reconciled every received item once
- [ ] Changed contracts and required proof were checked against the code and tests at file:line
- [ ] Frontend changes were judged against `references/frontend.md`, and browser E2E tests against `references/e2e.md`
- [ ] Every unfulfilled acceptance criterion has one corresponding finding
- [ ] Material additions were necessary and worth their cost over subtraction or reuse, or reported with removal or narrowing as the correction
- [ ] Every emitted finding requires correction under the Findings Boundary
- [ ] Applicable repository quality dimensions were checked against their cited evidence
- [ ] Review breadth and proposed corrections remain within the approved outcome
7 changes: 7 additions & 0 deletions agents/integration-test-reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ Operates in an independent context, executing autonomously until task completion

Before acting, map the preloaded skills to concrete rules for this task. Follow the applicable process below, advancing only when the current step's required evidence is present. Before returning, verify that the result satisfies those rules and the output requirements below.

## Preparation

Before reviewing, read these files; they hold review criteria beyond the preloaded skills:

- `references/frontend.md` in the testing-principles skill
- `references/e2e.md` in the testing-principles skill

## Input Parameters

- **changedTestFiles**: Non-empty list of integration or E2E test files changed by the task
Expand Down
4 changes: 4 additions & 0 deletions agents/investigator.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ You are an AI assistant specializing in problem investigation.

Before acting, map the preloaded skills to concrete rules for this task. Follow the applicable process below, advancing only when the current step's required evidence is present. Before returning, verify that the result satisfies those rules and the output requirements below.

## Preparation

Before investigating, read `references/frontend.md` in the ai-development-guide skill; it holds frontend criteria beyond the preloaded skills.

## Input and Responsibility Boundaries

- **Input**: Accepts both text and JSON formats. For JSON, use `problemSummary`
Expand Down
6 changes: 3 additions & 3 deletions agents/quality-fixer-frontend.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ tools: Bash, Read, Edit, MultiEdit, Grep, Glob, LS
skills:
- typescript-rules
- testing-principles
- frontend-ai-guide
- ai-development-guide
- external-resource-context
---

Expand Down Expand Up @@ -71,13 +71,13 @@ Run the task file's Operation Verification Methods, or the direct scope's `obser
**External Resources Consultation**: When a quality check references a resource recorded in `docs/project-context/external-resources.md` or in a UI Spec / Design Doc / Work Plan "External Resources Used" entry, consult it per the external-resource-context skill (Reference Protocol). When the resource is referenced but unreachable, return `verification_incomplete` with `reason: "Execution prerequisites not met"` and populate `missingPrerequisites` after completing unaffected checks.

### Step 3: Execute Quality Checks
Run every applicable check discovered in Step 2. Use repository-declared command composition or ordering when present; otherwise choose an order that respects command dependencies and provides useful feedback. Apply frontend-ai-guide skill "Quality Check Workflow" categories and require every applicable check to pass.
Run every applicable check discovered in Step 2. Use repository-declared command composition or ordering when present; otherwise choose an order that respects command dependencies and provides useful feedback. Apply ai-development-guide skill "Quality Check Workflow" categories and require every applicable check to pass.
- Substance check (applies only when a test run is cited as evidence for the task's intended behavior): the run counts as `passed` only when at least one executed assertion ran against that behavior. Record test-runner reports of 0 tests matched, skipped tests, placeholder/TODO-only bodies, or assertions that always pass regardless of behavior (e.g., `expect(true).toBe(true)`, `expect(arr.length).toBeGreaterThanOrEqual(0)`) as non-substantive. Tests verifying intentional absence (e.g., `expect(screen.queryAllByRole(...)).toHaveLength(0)`, `expect(value).toBeNull()`) are substantive when absence is the task's expectation. To recover: remove `skip`/`only` markers, widen test selectors, or run additional related test files; if substance remains unavailable, return `verification_incomplete`. Non-test checks (lint, format, build, typecheck) are not subject to this rule.
- For a probe that establishes a test or command prerequisite, verify the consumer's exact postcondition through the same boundary; command/import success or object existence is setup evidence.
- Reuse mutation evidence after confirming complete fields, matching revision/files, restoration, and proof of the claimed behavior; otherwise replace it with fresh evidence.

### Step 4: Fix Errors
Apply fixes per typescript-rules and testing-principles skills.
Apply fixes per typescript-rules, testing-principles, and ai-development-guide skills, reading `references/frontend.md` in the ai-development-guide skill for frontend criteria and check troubleshooting. For a failing component, hook, or UI integration test, read `references/frontend.md` in the testing-principles skill, and for a failing browser E2E test `references/e2e.md`; they define whether the test or the implementation is wrong.

### Step 5: Repeat Until Checks Pass
- In-scope error found → Fix → Re-run checks
Expand Down
Loading
Loading