Repository navigation
Review large changes in units and give agents the frontend and test criteria they judge by - #200
Merged
Merged
Conversation
…riteria they judge by - Split post-implementation code review of Large changes into units of Work Plan tasks, run at most 3 at a time; Medium changes keep one reviewer - Remove the acceptance-criteria inventory, full-change map, and fixed review order from code-reviewer, and require every material surface in implementationFiles to be judged before the verdict - Merge frontend-ai-guide into ai-development-guide: React/TypeScript-specific criteria move to references/frontend.md and frontend agents preload ai-development-guide - Have reviewers, investigators, and designers read the frontend and E2E references before their work without conditions, and have executors and fixers read them at the step that uses them - List test files in task Target Files only when the Work Plan fixes them, and stop deferring test quality to downstream checks in task executors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Remove the task executors' rule that synced [ ], [🔄], and [x] across the task file, Work Plan, and Design Doc - Add a final gate item: for task-file execution, each Completion Criteria item in the task file is satisfied with evidence in the response Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems and changes
One reviewer could not read a Large change in full
A single code-reviewer call covered every task of a Large change, so it read only a small part of the changed tests and missed duplicated proof and unused code.
code-reviewer spent its effort on inventories instead of reading code
code-reviewer had to list every acceptance criterion, including fulfilled ones, and map the whole change in a fixed order before judging it. No consumer used the fulfilled entries.
implementationFilesto be judged before the verdict.Frontend criteria did not reach shared agents
ai-development-guide and frontend-ai-guide repeated the same general criteria. Shared agents such as code-reviewer, investigator, verifier, and solver loaded only ai-development-guide, so they never received the React/TypeScript criteria.
ai-development-guide/references/frontend.md, and the frontend agents preload ai-development-guide.Agents skipped references that they were told to read conditionally
When an agent was told to read a reference only under a condition, such as "for frontend code", it skipped the reference even when the condition held.
Task files decided which tests to write
Task files listed test files in Target Files, and executors wrote tests file by file instead of choosing them by behavior. Executors also left test quality to downstream checks that only run tests.
Breaking change
The
frontend-ai-guideskill no longer exists. Useai-development-guideand itsreferences/frontend.mdinstead.🤖 Generated with Claude Code