Repository navigation
Conversation
1. Default pglite parameter to true in generate function. 2. Default pglite CLI option to true in pgstrap generate command. 3. Clean up PGlite database and pg-gateway server inside finally block. 4. Update README documentation to describe in-memory generation and --no-pglite opt out. 5. Add unit test verifying generate defaults to pglite without external PostgreSQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves issue #2 by defaulting type generation to an in-memory PGlite instance, allowing
bun run db:generateto run hermetically without requiring a background PostgreSQL server.Summary of Changes
generateinsrc/generate.tsso thatpglitedefaults totrue.try ... finallyblock to guarantee server shutdown and database closure.generatecommand insrc/cli.tsto default--pglitetotrue, providing--no-pgliteas an explicit opt-out to generate against external PostgreSQL.tests/generate.pglite.test.tsverifying that omittingpgliteruns migrations and generates types through PGlite.README.mddocumentation to describe default in-memory type generation and the--no-pgliteopt-out.Claim
Verified profile: https://terminal.merit.systems/aipd506
/claim #2