fix: adopt immutable pin and main import governance checks - #131
Conversation
58ba832 to
46a02ed
Compare
There was a problem hiding this comment.
Deterministic Validator approval for exact head 46a02edd31e7f882d7bef0becfdd8939060d0d19.
Ticket: ticket-091
Correlation ID: local-semcod-goal-pr-131-ticket-091
Model: zai/glm-5.3
Package advisory authority: ADVISORY (promotion FORBIDDEN)
Package digest: d98151916c75479d0b3f6a80908d73fd081d8a9ceb80962acc068f129302c1c4
Package evidence digest: b834efd249f30647a9b13179a1a30b19a70190b6b54e4ffd22346e7341826cd4
Package files: 6; high-risk samples: .githooks/pre-commit, .governance/worktree_overlap_check.py, .governance/manifest.json
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Adoption of published wellmanifest/new-project 0.20.12 at immutable revision bf30996, aligning pyproject.toml, manifests, and governance tooling. High-risk samples show the pre-commit hook re-scoped to pin verification only, a conservative main-import exemption in worktree_overlap_check.py, and a version bump in manifest.. All visible checks pass (Python 3.12/3.13, governance enforce, remote lifecycle). The package advisory is marked promotion FORBIDDEN and is correctly treated as non-authoritative; visible semantic content is consistent with the stated intent and ticket scope.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Actual PR impact radar
Exact range: b3abc2660105a82050c61e7ea55b4381d391e881...46a02edd31e7f882d7bef0becfdd8939060d0d19
Change digest: 442c274d7c8df7c4d2344231ec92d947aec0a3be79b62e470a31771c43a42ab9
Score: 60/100 (L), estimated 73 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":165,"base_sha":"b3abc2660105a82050c61e7ea55b4381d391e881","binary_files":0,"categories":{"code":2,"configuration":5,"docs":2},"change_digest":"442c274d7c8df7c4d2344231ec92d947aec0a3be79b62e470a31771c43a42ab9","comparison":"b3abc2660105a82050c61e7ea55b4381d391e881...46a02edd31e7f882d7bef0becfdd8939060d0d19","deletions":36,"file_count":9,"files":["githooks/pre-commit","governance/error/GOV-STANDARD-UPDATE.md","governance/manifest.base.json","governance/manifest.json","governance/manifest.lock.json","governance/worktree_overlap_check.py","project/ticket-091/README.md","project/ticket-091/intent.json","pyproject.toml"],"head_sha":"46a02edd31e7f882d7bef0becfdd8939060d0d19","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":3,"scope":4,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":73,"within_budget":false},"impact":{"components":["githooks","governance","project","repository-root"],"files":["githooks/pre-commit","governance/error/GOV-STANDARD-UPDATE.md","governance/manifest.base.json","governance/manifest.json","governance/manifest.lock.json","governance/worktree_overlap_check.py","project/ticket-091/README.md","project/ticket-091/intent.json","pyproject.toml"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":60,"split":{"parts":[{"estimated_minutes":16,"name":"Implement githooks","scope":["githooks"]},{"estimated_minutes":16,"name":"Implement governance","scope":["governance"]},{"estimated_minutes":16,"name":"Implement project","scope":["project"]},{"estimated_minutes":16,"name":"Implement repository-root","scope":["repository-root"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-091"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-091: fix: adopt immutable pin and main import governance checks</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,30 97,53 79,85 59,71 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 73m</text></svg>DECISION D-091-3417
TICKET ticket-091
HEAD_SHA 46a02edd31e7f882d7bef0becfdd8939060d0d19
CORRELATION_ID local-semcod-goal-pr-131-ticket-091
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT advisory_package_receipt = {"binding":{"repository":"semcod/goal","pull_request":131,"base_branch":"main","base_sha":"b3abc2660105a82050c61e7ea55b4381d391e881","head_sha":"46a02edd31e7f882d7bef0becfdd8939060d0d19","policy_digest":"1f3181e2c898c53d3c1a95651a2634be483658717ac9105b77ea206520cb5e62","registry_digest":"99020d4d733829fcc4d4bfb1e8faa6fb5522a0f87aad97e4de0413a755d1f5ad"},"package_digest":"d98151916c75479d0b3f6a80908d73fd081d8a9ceb80962acc068f129302c1c4","evidence_digest":"b834efd249f30647a9b13179a1a30b19a70190b6b54e4ffd22346e7341826cd4","package_file_count":6,"samples":[{"path":".githooks/pre-commit","risk":"executable,git-hook","diff_digest":"4c1adf33bba5678648644f1bc244872a4f2703bc225fc1baaf81056e8c123137","sample_digest":"5246da007ed4bfd2584a9842ade7a1459fb0cc70d71764fb747e644ce50f5a7f"},{"path":".governance/worktree_overlap_check.py","risk":"executable,code","diff_digest":"1f2c068454c95b9cb305c8a50f93e8a3ada9abcf03044fbc14076e84305c2178","sample_digest":"eeaebcfc1ae832437afbd02de31d0f2f0f75917046bc418a1b7dfa1aae22187b"},{"path":".governance/manifest.json","risk":"extendable","diff_digest":"35fabcf0009b15b7de5e70322626b151b4227893d3d5b99f6aaa1e174a7724ea","sample_digest":"35fabcf0009b15b7de5e70322626b151b4227893d3d5b99f6aaa1e174a7724ea"}],"authority":"ADVISORY","promotion":"FORBIDDEN"}
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test (3.13)=PASS","governance / remote lifecycle=PASS","test (3.12)=PASS","governance / enforce=PASS"]
INPUT required_checks = ["test (3.12)","test (3.13)"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"b3abc2660105a82050c61e7ea55b4381d391e881","head_sha":"46a02edd31e7f882d7bef0becfdd8939060d0d19","change_digest":"442c274d7c8df7c4d2344231ec92d947aec0a3be79b62e470a31771c43a42ab9","score":60,"complexity":"L","estimated_minutes":73,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
The pre-commit hook attempted a latest-standard upgrade during an unrelated artifact action update, blocking publication. Adopt published new-project 0.20.12 at bf3099667babd14ee778917d911d6c6bad45dcab: commits verify immutable local pins, and workspace checks recognize unchanged main imports. Preserve target settings and align package declarations.
Validation: managed governance passed; 723 tests passed, 2 skipped; Docker Compose and whitespace checks passed. This is the prerequisite for the pending artifact action update.
Ticket: ticket-091