Add serialization for: EthDot3, VLAN, VXLAN, LLC, SLL, SLL2, MPLS, Null/loopback, TPKT, WOL - #2277
Merged
Merged
Conversation
…LLC, SLL, SLL2, MPLS, Null/loopback, TPKT, WOL
seladb
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2277 +/- ##
==========================================
+ Coverage 82.61% 82.69% +0.08%
==========================================
Files 339 339
Lines 61875 62024 +149
Branches 13036 12830 -206
==========================================
+ Hits 51115 51289 +174
+ Misses 9877 9855 -22
+ Partials 883 880 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
50 tasks
seladb
marked this pull request as ready for review
September 28, 2026 08:35
seladb
requested review from
Dimi1010,
clementperon,
egecetin and
tigercosmos
September 28, 2026 08:35
Dimi1010
approved these changes
Sep 28, 2026
Dimi1010
left a comment
Dimi1010
left a comment
Collaborator
There was a problem hiding this comment.
Overall, LGTM.
But, I have some concerns about SerializedFields structs inside the layers since they shadow the same structs inside the base class. This might get messy down the line. 🤔
…ializedFields` - Add `@brief` to all `SerializedFields` fields
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds serialization support for the following layers, following the pattern introduced in : EthDot3, VLAN, VXLAN, LLC, SLL, SLL2, MPLS, Null/Loopback, TPKT and Wake-on-LAN.
Each layer now:
SerializedFieldsstruct with aFieldDescriptorper field and anall()method that returns the layer's fields together with those ofLayer::SerializedFieldsserializeLayer(ObjectScope&)to write those fields