Conversation
seladb
commented
Sep 18, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #2261 +/- ##
==========================================
- Coverage 82.68% 82.64% -0.04%
==========================================
Files 339 339
Lines 62024 62285 +261
Branches 13095 13172 +77
==========================================
+ Hits 51285 51478 +193
- Misses 9862 9931 +69
+ Partials 877 876 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
seladb
marked this pull request as ready for review
September 19, 2026 09:12
seladb
requested review from
Dimi1010,
clementperon,
egecetin and
tigercosmos
September 19, 2026 09:12
Dimi1010
reviewed
Sep 27, 2026
50 tasks
Dimi1010
reviewed
Sep 28, 2026
Dimi1010
left a comment
Dimi1010
left a comment
Collaborator
There was a problem hiding this comment.
I think this should be the last couple of things.
Comment on lines
365
to
372
| IPv6Extension* curExt = m_FirstExtension; | ||
| while (curExt != nullptr) | ||
| { | ||
| switch (curExt->getExtensionType()) | ||
| { | ||
| case IPv6Extension::IPv6Fragmentation: | ||
| result += "Fragment,"; | ||
| break; | ||
| case IPv6Extension::IPv6HopByHop: | ||
| result += "Hop-By-Hop,"; | ||
| break; | ||
| case IPv6Extension::IPv6Destination: | ||
| result += "Destination,"; | ||
| break; | ||
| case IPv6Extension::IPv6Routing: | ||
| result += "Routing,"; | ||
| break; | ||
| case IPv6Extension::IPv6AuthenticationHdr: | ||
| result += "Authentication,"; | ||
| break; | ||
| default: | ||
| result += "Unknown,"; | ||
| break; | ||
| } | ||
|
|
||
| result += curExt->getExtensionTypeAsString(); | ||
| result += ","; | ||
| curExt = curExt->getNextHeader(); | ||
| } |
Collaborator
There was a problem hiding this comment.
nit: while we are changing this, it can be changed to a for-loop.
for(IPv6Extension const* curExt = m_FirstExtension; curExt != nullptr; curExt = curExt->getNextHeader())
Collaborator
There was a problem hiding this comment.
curExt = curExt->getNextHeader(); in the loop body needs to be removed.
…ializedFields` - Add `@brief` to all `SerializedFields` fields
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds concrete
serializeLayer()implementations for the core protocol layers, building on the serialization framework from #2259.What's included:
EthLayer: source/destination MAC address, EtherTypeIPv4Layer: source/destination IP, ID, protocol, total length, fragmentation, optionsIPv6Layer: source/destination IP, payload length, fragmentation, next header, extension headersTcpLayer: ports, sequence number, flags, window size, checksum, optionsUdpLayer: ports, checksumBase branch is
packet-serialization-foundation(#2259)