Conversation
- Add `serializePackets()` to serialize a pcap file
seladb
changed the title
PacketSerializer, serializePackets)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## protocol-layer-serialization #2267 +/- ##
================================================================
+ Coverage 82.56% 82.67% +0.10%
================================================================
Files 339 340 +1
Lines 62134 62217 +83
Branches 12880 12759 -121
================================================================
+ Hits 51303 51435 +132
+ Misses 9951 9918 -33
+ Partials 880 864 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
seladb
marked this pull request as ready for review
September 21, 2026 08:21
seladb
requested review from
Dimi1010,
clementperon,
egecetin and
tigercosmos
September 21, 2026 08:21
Dimi1010
reviewed
Sep 21, 2026
Comment on lines
+81
to
+82
| PacketSerializer(const PacketSerializer&) = delete; | ||
| PacketSerializer& operator=(const PacketSerializer&) = delete; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds serialization support for collections of packets, building on the packet/layer serialization framework from #2259.
What's included:
PacketSerializer: serializes a collection of packets into one JSON array, viaaddPacket()/addPackets()serializePackets(): reads every packet from anIFileReaderDeviceand serializes them into one array, returning the packet countPacketUtilsTests.cppandFileTests.cppDepends on #2261.
Part of the packet serialization series (see #2259).