fix(config): read client API keys from CPA v8 layout - #887
Merged
Merged
Conversation
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After CPA v8 moves client keys to
access.api-keys, opening the visual configuration page shows an empty API Key list even though the keys still work. Read the effective v8 client-key field on initial load, while retaining older configurations and keeping upstream provider credential groups separate.Scope
Changes
access.api-keysprecedence, including empty lists and null; retain the legacy fallback when it is absent.api-keysprovider-group mapping and avoid reviving stale legacy keys when clearing client keys.User Impact
Existing CPA v8 client keys appear immediately when opening or reloading Settings. Users no longer need to attempt a key mutation to populate the list.
Compatibility / Runtime Notes
/api-keysendpoints and canonical read-back. The YAML write change protects the hook's serialization path; normal card CRUD does not use that path.Data / Security Notes
No database, authentication or secret-storage changes. Client keys cannot replace the top-level upstream credential groups. Fixtures and screenshots use synthetic keys only.
Risk / Rollback
Risk: low; limited to client-key YAML parsing/serialization. Revert this commit to restore previous behavior.
Verification
Commands / evidence (from
apps/web; invoked with the existing local Node binaries):keysgroup structure before final focused verification.Screenshots / Recordings
Initial display from v8 YAML, before any key mutation (synthetic keys):
Docs
Docs decision: restores existing API Key behavior after an upstream layout change; no new controls or setup steps. A bug-fix release note is appropriate.
Related
Fixes #886. This is a necessary upstream compatibility fix within the 1.x maintenance scope described in #884.