fix: fall back to asarray when DLPack export of a read-only index fails; buffer error fix - #2561
Draft
amalia-k510 wants to merge 1 commit into
Draft
fix: fall back to asarray when DLPack export of a read-only index fails; buffer error fix#2561amalia-k510 wants to merge 1 commit into
amalia-k510 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2561 +/- ##
==========================================
- Coverage 87.81% 85.84% -1.97%
==========================================
Files 49 49
Lines 7799 7802 +3
==========================================
- Hits 6849 6698 -151
- Misses 950 1104 +154
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was running into issues with certain scanpy tests when testing with jax arrays. Example:
This is the same problem we already handle in
__array__a few lines above, where the comment notes we can't round-trip jax arrays through DLPack and should let numpy handle it inasarrayinstead.The fix keeps
from_dlpackas the fast path and only falls back toasarrayif it actually fails. The array API spec saysfrom_dlpackraisesBufferErrorin exactly this case, so catching it is the intended way to handle it.