Skip to content

Use the shared Scrollkeeper bridge from TablesideShared - #36

Merged
scooper4711 merged 2 commits into
mainfrom
refactor/shared-scrollkeeper-bridge
Nov 15, 2026
Merged

scooper4711 merged 2 commits into
mainfrom
refactor/shared-scrollkeeper-bridge

Conversation

@scooper4711

Copy link
Copy Markdown
Owner

Closes #21.

Mapsmith's ScrollkeeperBridge, ScrollkeeperIndex, ScrollkeeperRequest, ApplicationLauncher, WorkspaceLauncher and cover thumbnail give way to those in tabletop-kit's TablesideShared (1.1.0).

  • ScrollkeeperBridgeConfiguration.mapsmith: key and status scheme mapsmith, the titles of kind "Maps" (kind left out of the subtitle and search, as before), PDFs and images, several requests side by side, Download.
  • The window and the iPad sheet are unchanged; PadLauncher stays here and conforms to the shared protocol.
  • The bridge's own tests moved to tabletop-kit; MapsmithScrollkeeperTests covers the configuration.
  • Specs updated (open-from-scrollkeeper, ipad-app).

One difference that comes with the shared bridge: asking for the list again forgets only the requests that are done or failed and keeps those under way, where Mapsmith's own bridge forgot them all.

Stacked on #35 (which is stacked on #33).

Checked: swiftlint --strict, scripts/coverage.sh (97 tests; MapsmithCore 98.5% lines, 91.7% regions), and an iPad simulator build.

Mapsmith's ScrollkeeperBridge, ScrollkeeperIndex, ScrollkeeperRequest,
ApplicationLauncher and cover thumbnail give way to those in
TablesideShared (tabletop-kit 1.1.0), configured for Mapsmith: key and
status scheme mapsmith, the titles of kind "Maps" without their kind,
PDFs and images, several requests side by side. The bridge's own tests
moved to tabletop-kit; Mapsmith keeps those of its configuration.

Closes #21
Base automatically changed from feat/new-from-clipboard to main November 15, 2026 19:46
@scooper4711
scooper4711 merged commit eb1cd5e into main Nov 15, 2026
2 checks passed
@scooper4711
scooper4711 deleted the refactor/shared-scrollkeeper-bridge branch November 15, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the shared Scrollkeeper bridge from TablesideShared

1 participant