Repository navigation
Use the shared Scrollkeeper bridge from TablesideShared - #36
Merged
Merged
Conversation
Mapsmith's ScrollkeeperBridge, ScrollkeeperIndex, ScrollkeeperRequest, ApplicationLauncher and cover thumbnail give way to those in TablesideShared (tabletop-kit 1.1.0), configured for Mapsmith: key and status scheme mapsmith, the titles of kind "Maps" without their kind, PDFs and images, several requests side by side. The bridge's own tests moved to tabletop-kit; Mapsmith keeps those of its configuration. Closes #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21.
Mapsmith's
ScrollkeeperBridge,ScrollkeeperIndex,ScrollkeeperRequest,ApplicationLauncher,WorkspaceLauncherand cover thumbnail give way to those in tabletop-kit'sTablesideShared(1.1.0).ScrollkeeperBridgeConfiguration.mapsmith: key and status schememapsmith, the titles of kind "Maps" (kind left out of the subtitle and search, as before), PDFs and images, several requests side by side, Download.PadLauncherstays here and conforms to the shared protocol.MapsmithScrollkeeperTestscovers the configuration.open-from-scrollkeeper,ipad-app).One difference that comes with the shared bridge: asking for the list again forgets only the requests that are done or failed and keeps those under way, where Mapsmith's own bridge forgot them all.
Stacked on #35 (which is stacked on #33).
Checked:
swiftlint --strict,scripts/coverage.sh(97 tests; MapsmithCore 98.5% lines, 91.7% regions), and an iPad simulator build.