Skip to content

Read the shared library instead of asking Scrollkeeper for the map index - #37

Merged
scooper4711 merged 2 commits into
mainfrom
refactor/shared-library-only
Nov 15, 2026
Merged

scooper4711 merged 2 commits into
mainfrom
refactor/shared-library-only

Conversation

@scooper4711

Copy link
Copy Markdown
Owner

Closes #34.

On the Mac, Open from Scrollkeeper now reads only the library Scrollkeeper shares in the App Group, as the iPad app does. Download and open requests for maps not on disk stay.

  • ScrollkeeperBridgeConfiguration.mapsmith sets asksForIndex = false (tabletop-kit 1.2.0, Let an app read only Scrollkeeper's library list tabletop-kit#46).
  • AppDelegate no longer takes .scrollkeeperindex files, and Info.plist drops the document type and the imported io.github.scooper4711.scrollkeeper.index type.
  • The browser loses its "Asking Scrollkeeper…" and "Scrollkeeper Hasn't Answered" states. Without a shared library it says "No Maps from Scrollkeeper Yet" with Open Scrollkeeper, and lists the maps as soon as Scrollkeeper shares them. A library in a newer format asks the user to update Mapsmith (on the iPad too, where it used to read as no library).
  • Specs (open-from-scrollkeeper, app-sandbox), README, PRIVACY and the build script comment updated. README now asks for Scrollkeeper 2.0 or later, the first to share its library.

Consequences to weigh:

  • An ad hoc build isn't in the App Group, so its Open from Scrollkeeper lists no maps; it used to fall back to the index.
  • Scrollkeeper older than 2.0 no longer works with Mapsmith.

Stacked on #36.

Checked: swiftlint --strict, scripts/coverage.sh (97 tests; MapsmithCore 98.5% lines, 91.7% regions), scripts/build-app.sh and an iPad simulator build. I did not drive the window by hand.

Open from Scrollkeeper on the Mac no longer asks Scrollkeeper for the
map index when the shared library can't be read, and no longer takes
.scrollkeeperindex files: the bridge is configured not to ask for the
index (tabletop-kit 1.2.0), as the iPad app already worked. Without a
library the window says so and lists the maps once Scrollkeeper shares
them. Requests to download or open a map not on disk stay.

Closes #34
Base automatically changed from refactor/shared-scrollkeeper-bridge to main November 15, 2026 19:46
@scooper4711
scooper4711 merged commit 354d95a into main Nov 15, 2026
2 checks passed
@scooper4711
scooper4711 deleted the refactor/shared-library-only branch November 15, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read the shared library instead of asking Scrollkeeper for the map index

1 participant