Repository navigation
Read the shared library instead of asking Scrollkeeper for the map index - #37
Merged
Merged
Conversation
Open from Scrollkeeper on the Mac no longer asks Scrollkeeper for the map index when the shared library can't be read, and no longer takes .scrollkeeperindex files: the bridge is configured not to ask for the index (tabletop-kit 1.2.0), as the iPad app already worked. Without a library the window says so and lists the maps once Scrollkeeper shares them. Requests to download or open a map not on disk stay. Closes #34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34.
On the Mac, Open from Scrollkeeper now reads only the library Scrollkeeper shares in the App Group, as the iPad app does. Download and open requests for maps not on disk stay.
ScrollkeeperBridgeConfiguration.mapsmithsetsasksForIndex = false(tabletop-kit 1.2.0, Let an app read only Scrollkeeper's library list tabletop-kit#46).AppDelegateno longer takes.scrollkeeperindexfiles, andInfo.plistdrops the document type and the importedio.github.scooper4711.scrollkeeper.indextype.open-from-scrollkeeper,app-sandbox), README, PRIVACY and the build script comment updated. README now asks for Scrollkeeper 2.0 or later, the first to share its library.Consequences to weigh:
Stacked on #36.
Checked:
swiftlint --strict,scripts/coverage.sh(97 tests; MapsmithCore 98.5% lines, 91.7% regions),scripts/build-app.shand an iPad simulator build. I did not drive the window by hand.