Add regression test for the Ammonite console on JDK > 8#2941
Open
jozanek wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Also see jozanek#1, if you like my proposal I can merge it to this PR (or later to master). |
Contributor
Author
|
failing test can be rerun, looks like flaky one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1226
Summary
bloop console <project>historically failed on JDK > 8 with:This was an upstream Ammonite / JDK 9+ issue (com-lihaoyi/Ammonite#1035): on JDK > 8 the Scala compiler can't locate the platform classes (
rt.jar/sun.boot.class.pathwere removed). It was never bloop-specific — even a directcoursier launch com.lihaoyi:ammonite_2.13.3:2.3.8failed identically.It no longer reproduces on current
main: the console emits acoursier launch …command that the CLI runs with the user's own coursier (#2856 / #2568), defaults to alatest.releaseAmmonite that supports JDK > 8, and no longer passes the old--scala-versionflag.Verified on JDK 17.