improvement: Resolve console REPL artifacts via coursier API instead of the CLI#1
Open
jozanek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
fix/1226-ammonite-console(upstream PR scalacenter#2941); review shows just the single follow-up commit.bloop consoleshelled out to acoursier/cslauncher on the client's PATH and requestedammonite_<exactScalaVersion>:latest.release. So it failed with a bare "command not found" when no launcher was present, and with a raw coursier stack trace when Ammonite wasn't published for the project's exact Scala version.This resolves the REPL artifacts with bloop's existing coursier API (
DependencyResolution) and emits a plainjava -cp ... <main>command instead:javais needed);Applies to both the Ammonite and Scala REPLs.
ConsoleSpecnow launches the generated command end-to-end and asserts the project's classes are visible in the REPL.