Repository navigation
fix(security): close the pre-publication audit findings - #11
Merged
Merged
Conversation
A read-only review before going public found ways a scanned repository could act on the machine running Wirehouse or on the page it draws: - git ran a nested repository's clean filters during `git status` - a linked `wirehouse-out` sent every output file elsewhere - crafted strings made redaction quadratic (minutes per file) - a checked-in archmap.raw.json could run script in the page - `redis://:password@host` was not redacted - deeply nested manifests crashed the scan - line breaks in names could add sections to the agent brief Each has a regression test that fails on the previous code. The release workflow pins the PyPI publish action to a commit and the release job's tools to versions, and checkouts drop their token.
This was referenced Oct 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A read-only security review before the repository goes public. Each finding below was reproduced first, and each now has a regression test that fails on the previous code.
git statusran a nested repository's clean filters (the existing guard only read the outer config)--ignore-submodules=allandsubmodule.recurse=falsewirehouse-outlink or junction sent every output file wherever it pointedwirehouse-out(pass-oinstead); write each file through a temp file and a rename, which replaces a link instead of following it@Column(calls took minutesSECRET_LIKE, agent text cut before it is searched, column calls read at most 4,000 characters ahead. The same 192 KB file now builds in 1.3 sarchmap.raw.jsoncould run script in the page (unescaped file count in the block panel)https://addresses with an encoded revision;renderchecks citations against the folder on the command line; a checked-in raw map is flagged in the output and in Checksredis://:password@host(empty user) was not redacted+/.schemes;http://host:8080/docs@v2is no longer a false positiveRecursionErrorenrich-brief.md, which the agent reads as instructionspypa/gh-action-pypi-publish@release/v1on the job that can publishpersist-credentials: falseAlso: one home-folder test fixture now uses
alice, andTODO.mdrecords that CI cannot run while the repository is private (billing), which resolves itself once it is public.How I checked it
python -m pytestpasses: 168 passed, 2 skipped (file symlinks cannot be made on this Windows machine)node --check wirehouse/render/app.jsandpython -m pytest tests/test_viewer.py, including a new test that a hostile map cannot run script or makejavascript:linksCHANGELOG.mdupdated under Unreleased (Security)CI shows every job as failed after a few seconds: GitHub does not start Actions jobs on this private repository because of account billing, not because of this change.
Ground rules
archmap.jsonor the HTML