Repository navigation
fix(ci): pin pypi-publish to v1.14.3, drop finished setup todo - #12
Merged
Merged
Conversation
v1.14.2 bundles sigstore 4.5.0 and certifi 2025.8.3, which still trust the emSign root that was removed after the eMudhra incident. The publish job holds the PyPI token, so it should not run with a stale CA bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Three small follow-ups to #11, before the first PyPI release.
Pin the PyPI publish action to v1.14.3 (
7245906, checked against thev1.14.3tag in pypa/gh-action-pypi-publish). v1.14.2 bundles sigstore 4.5.0 and certifi 2025.8.3, which still trust the emSign root that was removed from CA bundles after the eMudhra incident. The publish job holds the PyPI token, so it should not run with a stale CA bundle.Drop the "Repository setup" section from TODO.md. The GitHub settings (About, topics, social preview, Pages, Discussions,
detectionlabel, vulnerability reporting, ruleset formain,pypienvironment) and the PyPI trusted publisher are in place, and CI runs now that the repository is public.Make
test_unclosed_orm_calls_parse_quicklyindependent of machine speed. It timed the parse against 5 seconds; the bounded parse takes 2 to 5 seconds depending on the machine, so it failed on a slow macOS runner (5.2 s) although the fix from fix(security): close the pre-publication audit findings #11 works. It now checks that every decorator call reads at mostMAX_CALL_ARGScharacters ahead. With that limit removed the test fails, as it should.How I checked it
python -m pytestpasses: 168 passed, 2 skipped (file symlinks cannot be made on this Windows machine)CHANGELOG.mdupdated under UnreleasedThe workflow change is exercised by the first release tag (
v0.3.1).Ground rules
archmap.jsonor the HTML