Rename recently added CRAM tests to the house naming convention - #1794
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Three test classes added in #1789, #1791 and #1792 used snake_case method names without the conventional test prefix, which is neither idiomatic Java nor what this repo does: of 2417 test methods, 2020 start with "test" and only 199 contain an underscore at all. Rename the nine offending methods in these three classes to testXxx camelCase. Test bodies are untouched; this is naming only.
95d52a3 to
d26c569
Compare
Follow-up hygiene on my own recent PRs — no behaviour change.
Three test classes added in #1789, #1791 and #1792 used snake_case method names without the conventional
testprefix. That is neither idiomatic Java nor what this repo does; measured acrosssrc/test/java:testThis renames the nine offending methods in those three classes to
testXxxcamelCase:CRAMContainerStreamWriterClosureTestCRAMFileReaderNonSeekableStreamTestReferenceSourceConcurrencyTestThe fourth affected class,
CRAMReferenceRegionErrorMessageTest(from #1790), has its three methods renamed in #1793 instead, since that file is already being modified there.Test bodies are untouched — naming only. Full CRAM suite green.