Skip to content

Rename recently added CRAM tests to the house naming convention - #1794

Merged
tfenne merged 1 commit into
masterfrom
tf_fix_test_naming
Jul 26, 2026
Merged

Rename recently added CRAM tests to the house naming convention#1794
tfenne merged 1 commit into
masterfrom
tf_fix_test_naming

Conversation

@tfenne

@tfenne tfenne commented Jul 26, 2026

Copy link
Copy Markdown
Member

Follow-up hygiene on my own recent PRs — no behaviour change.

Three test classes added in #1789, #1791 and #1792 used snake_case method names without the conventional test prefix. That is neither idiomatic Java nor what this repo does; measured across src/test/java:

  • 2020 of 2417 test methods start with test
  • only 199 of 2417 contain an underscore at all

This renames the nine offending methods in those three classes to testXxx camelCase:

Class Methods renamed
CRAMContainerStreamWriterClosureTest 4
CRAMFileReaderNonSeekableStreamTest 2
ReferenceSourceConcurrencyTest 3

The fourth affected class, CRAMReferenceRegionErrorMessageTest (from #1790), has its three methods renamed in #1793 instead, since that file is already being modified there.

Test bodies are untouched — naming only. Full CRAM suite green.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@tfenne, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d376fe7a-3d6b-474e-858a-09d71289eaf0

📥 Commits

Reviewing files that changed from the base of the PR and between a431e97 and d26c569.

📒 Files selected for processing (3)
  • src/test/java/htsjdk/samtools/cram/CRAMContainerStreamWriterClosureTest.java
  • src/test/java/htsjdk/samtools/cram/CRAMFileReaderNonSeekableStreamTest.java
  • src/test/java/htsjdk/samtools/cram/ref/ReferenceSourceConcurrencyTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tf_fix_test_naming

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Three test classes added in #1789, #1791 and #1792 used snake_case method names
without the conventional test prefix, which is neither idiomatic Java nor what
this repo does: of 2417 test methods, 2020 start with "test" and only 199
contain an underscore at all.

Rename the nine offending methods in these three classes to testXxx camelCase.
Test bodies are untouched; this is naming only.
@tfenne
tfenne force-pushed the tf_fix_test_naming branch from 95d52a3 to d26c569 Compare July 26, 2026 11:29
@tfenne
tfenne merged commit 7292f1c into master Jul 26, 2026
5 checks passed
@tfenne
tfenne deleted the tf_fix_test_naming branch July 26, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant