Rollup of 15 pull requests by JonathanBrouwer · Pull Request #163038 · rust-lang/rust

JonathanBrouwer · 2026-09-19T21:14:02Z

Successful merges:

Make let-else respect macro_rules expr metavariable grouping #158515 (Make let-else respect macro_rules expr metavariable grouping)
std: fix unix socket address panic on a full sun_path #162726 (std: fix unix socket address panic on a full sun_path)
Better account for Self that might be a typo of self #160028 (Better account for Self that might be a typo of self)
fix const_item_mutation lint to use needs_drop instead of has_dtor #160097 (fix const_item_mutation lint to use needs_drop instead of has_dtor)
Provide a supertrait_def_ids() function in rustc_type_ir's interner #161435 (Provide a supertrait_def_ids() function in rustc_type_ir's interner)
Do not suppress the fn item uniqueness note for late bound lifetimes #161894 (Do not suppress the fn item uniqueness note for late bound lifetimes)
post GH comment on types nominations #162990 (post GH comment on types nominations)
add safety section for mem::zeroed #154665 (add safety section for mem::zeroed)
Remove incorrect parse error recovery code that mistakes as casts for the long removed type ascription #162700 ( Remove incorrect parse error recovery code that mistakes as casts for the long removed type ascription)
Trigger "C array" parse error recovery in far fewer cases #162705 (Trigger "C array" parse error recovery in far fewer cases)
Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt #162875 (Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt)
recover true and false in type position as bool #162988 (recover true and false in type position as bool)
Constify impl FromStr for NonZero<T> #162995 (Constify impl FromStr for NonZero<T>)
Use end_point for trailing brace in let...else diagnostics #163006 (Use end_point for trailing brace in let...else diagnostics)
add Dir::try_clone #163007 (add Dir::try_clone)

rust-analyzer has a query for this, so we want to use it there. I don't know if using a query for this will be a perf win for rustc, but rust-analyzer already has this query for other reasons, so it feels a waste to not use it.

linux reports an address length one byte past sockaddr_un when the path fills sun_path without a NUL, which made address() slice out of bounds since e96993c. cap the length at the size of sockaddr_un.

…k_read_exact()

…, r=jhpratt Constify `impl FromStr for NonZero<T>` `<integer>::from_str` has been `const`. `NonZero::from_str` can also be `const`. rust-lang#143773

…e, r=folkertdev Use `end_point` for trailing brace in `let...else` diagnostics The following ICEs because `｝` is a fullwidth lookalike of `}`: ```rs fn main() { let x = {1｝ else { return; }; } ``` The diagnostic for a trailing curly brace before else in a let...else statement computed the brace span with `span.hi() - BytePos(1)`. That assumes the brace is a single ASCII byte.

@the8472

add Dir::try_clone There's no `try_clone` listed on rust-lang#120426 but I assume that's a standard operation for all kinds of file descriptors? Cc @the8472 @ChrisDenton

JonathanBrouwer · 2026-09-19T21:14:15Z

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-gnu-llvm-21-3,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu

rust-bors · 2026-09-19T21:14:17Z

📌 Commit 61eaf00 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 15 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu

rust-bors · 2026-09-19T21:14:47Z

⌛ Testing commit 61eaf00 with merge 99aa0fb...

Workflow: https://github.com/rust-lang/rust/actions/runs/35469823703

…uwer Rollup of 15 pull requests Successful merges: - #158515 (Make let-else respect macro_rules expr metavariable grouping) - #162726 (std: fix unix socket address panic on a full sun_path) - #160028 (Better account for `Self` that might be a typo of `self`) - #160097 (fix const_item_mutation lint to use needs_drop instead of has_dtor) - #161435 (Provide a `supertrait_def_ids()` function in rustc_type_ir's interner) - #161894 (Do not suppress the fn item uniqueness note for late bound lifetimes) - #162990 (post GH comment on types nominations) - #154665 (add safety section for mem::zeroed) - #162700 ( Remove incorrect parse error recovery code that mistakes `as` casts for the long removed type ascription) - #162705 (Trigger "C array" parse error recovery in far fewer cases) - #162875 (Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt) - #162988 (recover `true` and `false` in type position as `bool`) - #162995 (Constify `impl FromStr for NonZero<T>`) - #163006 (Use `end_point` for trailing brace in `let...else` diagnostics) - #163007 (add Dir::try_clone)

rust-log-analyzer · 2026-09-19T23:44:12Z

The job test-x86_64-mingw-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-09-19T23:54:00Z

PR #162875, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/35469823703

fmease · 2026-09-20T00:01:57Z

Sorry for unapproving a rollup member (for somewhat benign reasons) but I thought this rollup was doomed anyway due to the test-x86_64-mingw-1 failure but on a second look I'm not sure if it was spurious after all 🤔

rust-bors · 2026-09-20T00:13:45Z

💔 Test for 96521a5 failed: CI. Failed job:

try - test-x86_64-mingw-1 (web logs, enhanced plaintext logs)

rust-bors · 2026-09-20T00:29:56Z

PR #162875, which is a member of this rollup, changed its commit SHA.

This rollup was closed.

bb1yd and others added 30 commits June 28, 2026 20:33

fix

5e53d92

add safety section for mem::zeroed

a0b3416

fix const_item_mutation lint to use needs_drop instead of has_dtor

940498d

Add test for the fn item uniqueness note with late bound lifetimes

98a157a

Do not suppress the fn item uniqueness note for late bound lifetimes

21228c2

std: fix unix socket address panic on a full sun_path

4c3c97f

linux reports an address length one byte past sockaddr_un when the path fills sun_path without a NUL, which made address() slice out of bounds since e96993c. cap the length at the size of sockaddr_un.

First pass at windows::fs::FileExt.seek_read_exact()

ac0e9fa

First pass at windows::fs::FileExt.seek_write_all()

88af4fd

Fix function signature in seek_read_exact(), duh

535fa77

First pass at tests for .seek_read_exact(), seek_write_all()

5c56219

Whitespace fix

6df2dd9

Use hypothetical seek_read_exact_seek_write_all feature also for .see…

482f884

…k_read_exact()

Tracking issues 162868

165e755

Oops, fix seek_write_all() doc example, was using write_all_at() still

fafa1ee

Add mocked test for windows FileExt trait

d179246

Spelling fixes

c0785e4

Expand test for windows FileExt trait to include almost all scenarios

2adb748

Split three tests out of file_test_windows_fileext_trait()

1ee8475

Remove old versions of those 3 tests

c9c5a06

Split remaining file_test_windows_fileext_trait() into case 4, 5

66a3b72

More test cleanup, always test expected_offset where possible

71f10b4

Test read first for consistency

e9aaeef

Use same doctsring examples as seek_read(), seek_write()

c2218a7

Missing period

6ac2b72

post GH comment on types nominations

ee766dc

Constify impl FromStr for NonZero<T>

75b444d

Use end_point for trailing brace in let...else diagnostics

c30f2a4

add Dir::try_clone

1b3f10d

Oops: actually call _exact(), _all() methods in case 2, 3

bbdd298

JonathanBrouwer added 3 commits September 19, 2026 23:13

Rollup merge of rust-lang#162995 - sorairolake:const-nonzero-from-str…

123f86c

…, r=jhpratt Constify `impl FromStr for NonZero<T>` `<integer>::from_str` has been `const`. `NonZero::from_str` can also be `const`. rust-lang#143773

Rollup merge of rust-lang#163007 - RalfJung:dirfd-clone, r=ChrisDenton

61eaf00

add Dir::try_clone There's no `try_clone` listed on rust-lang#120426 but I assume that's a standard operation for all kinds of file descriptors? Cc @the8472 @ChrisDenton

rust-bors Bot added the rollup A PR which is a rollup label Sep 19, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot mentioned this pull request Sep 19, 2026

Make let-else respect macro_rules expr metavariable grouping #158515

Open

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2026

rust-bors Bot mentioned this pull request Sep 19, 2026

Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt #162875

Open

rust-bors Bot closed this Sep 20, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 20, 2026

Navigation Menu

Uh oh!

Rollup of 15 pull requests - #163038

Rollup of 15 pull requests#163038
JonathanBrouwer wants to merge 53 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-yYS0MxF

JonathanBrouwer commented Sep 19, 2026

Uh oh!

JonathanBrouwer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 19, 2026 •

edited

Loading

Uh oh!

rust-log-analyzer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

fmease commented Sep 20, 2026

Uh oh!

rust-bors Bot commented Sep 20, 2026

Uh oh!

rust-bors Bot commented Sep 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Conversation

JonathanBrouwer commented Sep 19, 2026

Uh oh!

JonathanBrouwer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

fmease commented Sep 20, 2026

Uh oh!

rust-bors Bot commented Sep 20, 2026

Uh oh!

rust-bors Bot commented Sep 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

rust-bors Bot commented Sep 19, 2026 •

edited

Loading