Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt by json420 · Pull Request #162875 · rust-lang/rust

json420 · 2026-09-16T23:11:58Z

Tracking issue: #162868

This adds .seek_read_exact() to std::os::windows::fs::FileExt, an exact port of read_exact_at() for std::os::unix::fs::FileExt.

And it adds .seek_write_all() to std::os::windows::fs::FileExt, an exact port of write_all_at() for std::os::unix::fs::FileExt.

Finally, it adds six tests.

First there is a smoke test for seek_read_exact(), seek_write_all(), an exact port of the test for the .seek_read(), .seek_write() methods. This is to make sure we are getting the same pass-through behavior through the lens of established tests.

Then there are five tests for the windows::fs::FileExt trait itself, covering all seek_read_exact(), seek_write_all() corner cases except io::ErrorKind::Interrupted (advise welcome on that one). These tests use mock implementations of the traits seek_read() and seek_write() methods.

No LLMs were used in writing this PR.

…k_read_exact()

rustbot · 2026-09-16T23:12:03Z

Thanks for the pull request, and welcome! The Rust Project has assigned @clarfonthey (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 13 candidates
Random selection from 6 candidates

clarfonthey · 2026-09-17T20:28:21Z

LGTM minus test splitting.

@rustbot author

rustbot · 2026-09-17T20:28:25Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

json420 · 2026-09-18T19:16:55Z

@rustbot ready

clarfonthey · 2026-09-18T19:49:35Z

@bors r+ rollup

Thank you!

rust-bors · 2026-09-18T19:49:38Z

📌 Commit 6ac2b72 has been approved by clarfonthey

It is now in the queue for this repository.

json420 · 2026-09-18T19:54:02Z

@clarfonthey No, thank you! Contributing to Rust is, like, a wildly pleasant experience for a first timer! Seriously. Thanks!

…they Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt Tracking issue: rust-lang#162868 This adds `.seek_read_exact()` to `std::os::windows::fs::FileExt`, an exact port of `read_exact_at()` for `std::os::unix::fs::FileExt`. And it adds `.seek_write_all()` to `std::os::windows::fs::FileExt`, an exact port of `write_all_at()` for `std::os::unix::fs::FileExt`. Finally, it adds six tests. First there is a smoke test for `seek_read_exact()`, `seek_write_all()`, an exact port of the test for the `.seek_read()`, `.seek_write()` methods. This is to make sure we are getting the same pass-through behavior through the lens of established tests. Then there are five tests for the `windows::fs::FileExt` trait itself, covering all `seek_read_exact()`, `seek_write_all()` corner cases except `io::ErrorKind::Interrupted` (advise welcome on that one). These tests use mock implementations of the traits `seek_read()` and `seek_write()` methods. No LLMs were used in writing this PR.

Rollup of 18 pull requests Successful merges: - #162499 (`rustc_codegen_gcc` subtree update) - #161424 (implement `VaArgSafe` for `f128`) - #161777 (Add Natvis visualiser and debuginfo tests for `f128`) - #162506 (Avoid suggesting imports of traits declared inside fn bodies) - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area) - #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names) - #162733 (Add useful APIs to `Unique(Arc|Rc)`) - #162913 (Refactor LivenessResults into LivenessComputation, without typeck) - #162950 (More AST lowering cleanups) - #162964 (Update `browser-ui-test` version to `0.25.2`) - #162979 (mark `f128` as reliable on `powerpc64` with `+vsx`) - #161743 (Add performance notes for the floating-point round method) - #162797 (yeet AliasConstKind::opt_def_id) - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports) - #162873 (Adjust `bug!`/`span_bug!` emission) - #162875 (Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt) - #162956 (Add missing `#[repr(C)]` in UI, codegen and assembly tests) - #162981 (rustc-dev-guide subtree update) Failed merges: - #162177 (Properly implement the gpu-kernel ABI for amdgpu)

JonathanBrouwer · 2026-09-19T06:01:22Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #162996 (comment)

rust-bors · 2026-09-19T06:01:31Z

This pull request was unapproved.

This PR was contained in a rollup (#162996), which was unapproved.

View changes since this unapproval

json420 added 7 commits September 16, 2026 10:48

First pass at windows::fs::FileExt.seek_read_exact()

ac0e9fa

First pass at windows::fs::FileExt.seek_write_all()

88af4fd

Fix function signature in seek_read_exact(), duh

535fa77

First pass at tests for .seek_read_exact(), seek_write_all()

5c56219

Whitespace fix

6df2dd9

Use hypothetical seek_read_exact_seek_write_all feature also for .see…

482f884

…k_read_exact()

Tracking issues 162868

165e755

rustbot assigned clarfonthey Sep 16, 2026

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 16, 2026

Oops, fix seek_write_all() doc example, was using write_all_at() still

fafa1ee

json420 mentioned this pull request Sep 17, 2026

Tracking Issue for seek_read_exact_seek_write_all #162868

Open

5 tasks

json420 added 3 commits September 17, 2026 09:27

Add mocked test for windows FileExt trait

d179246

Spelling fixes

c0785e4

Expand test for windows FileExt trait to include almost all scenarios

2adb748

clarfonthey reviewed Sep 17, 2026

View reviewed changes

Comment thread library/std/src/fs/tests.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2026

json420 marked this pull request as draft September 17, 2026 21:50

json420 added 7 commits September 18, 2026 12:10

Split three tests out of file_test_windows_fileext_trait()

1ee8475

Remove old versions of those 3 tests

c9c5a06

Split remaining file_test_windows_fileext_trait() into case 4, 5

66a3b72

More test cleanup, always test expected_offset where possible

71f10b4

Test read first for consistency

e9aaeef

Use same doctsring examples as seek_read(), seek_write()

c2218a7

Missing period

6ac2b72

json420 marked this pull request as ready for review September 18, 2026 19:11

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2026

Zalathar mentioned this pull request Sep 19, 2026

Rollup of 18 pull requests #162996

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2026

Navigation Menu

Uh oh!

Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt - #162875

Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt#162875
json420 wants to merge 18 commits into
rust-lang:mainfrom
json420:seek_read_exact

json420 commented Sep 16, 2026 •

edited

Loading

Uh oh!

rustbot commented Sep 16, 2026

Uh oh!

Uh oh!

clarfonthey commented Sep 17, 2026

Uh oh!

rustbot commented Sep 17, 2026

Uh oh!

json420 commented Sep 18, 2026

Uh oh!

clarfonthey commented Sep 18, 2026

Uh oh!

rust-bors Bot commented Sep 18, 2026

Uh oh!

json420 commented Sep 18, 2026

Uh oh!

JonathanBrouwer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

json420 commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 16, 2026

Uh oh!

Uh oh!

clarfonthey commented Sep 17, 2026

Uh oh!

rustbot commented Sep 17, 2026

Uh oh!

json420 commented Sep 18, 2026

Uh oh!

clarfonthey commented Sep 18, 2026

Uh oh!

rust-bors Bot commented Sep 18, 2026

Uh oh!

json420 commented Sep 18, 2026

Uh oh!

JonathanBrouwer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

json420 commented Sep 16, 2026 •

edited

Loading