Skip to content

Refactor LivenessResults into LivenessComputation, without typeck - #162913

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jackh726:trace-refactor
Sep 19, 2026
Merged

Refactor LivenessResults into LivenessComputation, without typeck#162913
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jackh726:trace-refactor

Conversation

@jackh726

@jackh726 jackh726 commented Sep 17, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

This refactor enables splitting out some liveness calculation to be deferred.

r? lqd

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 17, 2026
@jackh726

jackh726 commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

Disclosure: An LLM was used for experiments here, but all code here is written fresh.

@rust-bors

This comment has been minimized.

Sign in to view
@rust-cloud-vms
rust-cloud-vms Bot force-pushed the trace-refactor branch 2 times, most recently from a7b130c to 33a9201 Compare September 17, 2026 23:05
@jackh726 jackh726 changed the title Refactor LivenessResults into LivenessCalculation, without typeck Refactor LivenessResults into LivenessComputation, without typeck Sep 17, 2026
lqd
lqd approved these changes Sep 18, 2026
View reviewed changes

@lqd lqd left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, a few comments

View changes since this review

Comment thread compiler/rustc_borrowck/src/type_check/liveness/trace.rs Outdated
Comment thread compiler/rustc_borrowck/src/type_check/liveness/trace.rs Outdated
Comment thread compiler/rustc_borrowck/src/type_check/liveness/trace.rs Outdated
Comment thread compiler/rustc_borrowck/src/type_check/liveness/trace.rs Outdated
Comment thread compiler/rustc_borrowck/src/type_check/liveness/trace.rs Outdated
lqd
lqd reviewed Sep 18, 2026
View reviewed changes
Comment thread compiler/rustc_borrowck/src/type_check/liveness/trace.rs Outdated
lqd
lqd approved these changes Sep 18, 2026
View reviewed changes

@lqd lqd left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet.

But the legacy stuff is wild.

r=me with the comments below handled (the first suggestion may not be a good idea, but the other two seem interesting)

View changes since this review

Comment thread compiler/rustc_borrowck/src/type_check/liveness/trace.rs
Comment thread compiler/rustc_borrowck/src/type_check/liveness/trace.rs Outdated
Comment thread compiler/rustc_borrowck/src/type_check/liveness/trace.rs Outdated
@jackh726

jackh726 commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

@bors r=lqd

@rust-bors

rust-bors Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 806ba27 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 19, 2026
@jackh726

jackh726 commented Sep 19, 2026

Copy link
Copy Markdown
Member Author

@bors r=lqd

@rust-bors

rust-bors Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b2c6d2d has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 19, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 19, 2026
@Zalathar
Rollup merge of rust-lang#162913 - jackh726:trace-refactor, r=lqd
ad3325f 
Refactor LivenessResults into LivenessComputation, without typeck

This refactor enables splitting out some liveness calculation to be deferred.

r? lqd
@Zalathar Zalathar mentioned this pull request Sep 19, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
@bors
Auto merge of #162996 - Zalathar:rollup-uUWX3SP, r=Zalathar
1f3278c 
Rollup of 18 pull requests

Successful merges:

 - #162499 (`rustc_codegen_gcc` subtree update)
 - #161424 (implement `VaArgSafe` for `f128`)
 - #161777 (Add Natvis visualiser and debuginfo tests for `f128`)
 - #162506 (Avoid suggesting imports of traits declared inside fn bodies)
 - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area)
 - #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names)
 - #162733 (Add useful APIs to `Unique(Arc|Rc)`)
 - #162913 (Refactor LivenessResults into LivenessComputation, without typeck)
 - #162950 (More AST lowering cleanups)
 - #162964 (Update `browser-ui-test` version to `0.25.2`)
 - #162979 (mark `f128` as reliable on `powerpc64` with `+vsx`)
 - #161743 (Add performance notes for the floating-point round method)
 - #162797 (yeet AliasConstKind::opt_def_id)
 - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports)
 - #162873 (Adjust `bug!`/`span_bug!` emission)
 - #162875 (Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt)
 - #162956 (Add missing `#[repr(C)]` in UI, codegen and assembly tests)
 - #162981 (rustc-dev-guide subtree update)

Failed merges:

 - #162177 (Properly implement the gpu-kernel ABI for amdgpu)
rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
@bors
Auto merge of #162996 - Zalathar:rollup-uUWX3SP, r=tgross35
3d463a0 
Rollup of 18 pull requests

Successful merges:

 - #162499 (`rustc_codegen_gcc` subtree update)
 - #161424 (implement `VaArgSafe` for `f128`)
 - #161777 (Add Natvis visualiser and debuginfo tests for `f128`)
 - #162506 (Avoid suggesting imports of traits declared inside fn bodies)
 - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area)
 - #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names)
 - #162733 (Add useful APIs to `Unique(Arc|Rc)`)
 - #162913 (Refactor LivenessResults into LivenessComputation, without typeck)
 - #162950 (More AST lowering cleanups)
 - #162964 (Update `browser-ui-test` version to `0.25.2`)
 - #162979 (mark `f128` as reliable on `powerpc64` with `+vsx`)
 - #161743 (Add performance notes for the floating-point round method)
 - #162797 (yeet AliasConstKind::opt_def_id)
 - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports)
 - #162873 (Adjust `bug!`/`span_bug!` emission)
 - #162875 (Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt)
 - #162956 (Add missing `#[repr(C)]` in UI, codegen and assembly tests)
 - #162981 (rustc-dev-guide subtree update)

Failed merges:

 - #162177 (Properly implement the gpu-kernel ABI for amdgpu)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 19, 2026
@JonathanBrouwer
Rollup merge of rust-lang#162913 - jackh726:trace-refactor, r=lqd
ab52a76 
Refactor LivenessResults into LivenessComputation, without typeck

This refactor enables splitting out some liveness calculation to be deferred.

r? lqd
This was referenced Sep 19, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
@bors
Auto merge of #163002 - JonathanBrouwer:rollup-iOYYbuh, r=JonathanBro…
36b04f3 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #163001 (Temporarily disable `test-x86_64-fuchsia`)
 - #162880 (Mini optimization in `rustc_hir_typeck::upvar::restrict_precision_for_drop_types`)
 - #161424 (implement `VaArgSafe` for `f128`)
 - #161777 (Add Natvis visualiser and debuginfo tests for `f128`)
 - #162506 (Avoid suggesting imports of traits declared inside fn bodies)
 - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area)
 - #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names)
 - #162733 (Add useful APIs to `Unique(Arc|Rc)`)
 - #162913 (Refactor LivenessResults into LivenessComputation, without typeck)
 - #162924 (Remove applying inline attributes at the callsite)
 - #162940 (Use spawned `SBDebugger` instance)
 - #162950 (More AST lowering cleanups)
 - #162964 (Update `browser-ui-test` version to `0.25.2`)
 - #162979 (mark `f128` as reliable on `powerpc64` with `+vsx`)
 - #161743 (Add performance notes for the floating-point round method)
 - #162797 (yeet AliasConstKind::opt_def_id)
 - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports)
 - #162873 (Adjust `bug!`/`span_bug!` emission)
 - #162956 (Add missing `#[repr(C)]` in UI, codegen and assembly tests)
 - #162971 (libtest harness: avoid 'extern crate test' with custom runner)
 - #162981 (rustc-dev-guide subtree update)
 - #162985 (Error on invalid placements for unstable attributes)
@rust-bors
rust-bors Bot merged commit 1cd2490 into rust-lang:main Sep 19, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 19, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
@bors
Unrolled build for #162913 in rollup 163002
6e66f8c 
Rollup merge of #162913 - jackh726:trace-refactor, r=lqd

Refactor LivenessResults into LivenessComputation, without typeck

This refactor enables splitting out some liveness calculation to be deferred.

r? lqd
@jackh726
jackh726 deleted the trace-refactor branch September 19, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kobzol Kobzol Kobzol left review comments
@lqd lqd lqd approved these changes

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jackh726 @lqd @Kobzol @rustbot