Rollup of 20 pull requests by JonathanBrouwer · Pull Request #163000 · rust-lang/rust

JonathanBrouwer · 2026-09-19T06:02:06Z

Successful merges:

Mini optimization in rustc_hir_typeck::upvar::restrict_precision_for_drop_types #162880 (Mini optimization in rustc_hir_typeck::upvar::restrict_precision_for_drop_types)
implement VaArgSafe for f128 #161424 (implement VaArgSafe for f128)
Add Natvis visualiser and debuginfo tests for f128 #161777 (Add Natvis visualiser and debuginfo tests for f128)
Properly implement the gpu-kernel ABI for amdgpu #162177 (Properly implement the gpu-kernel ABI for amdgpu)
Avoid suggesting imports of traits declared inside fn bodies #162506 (Avoid suggesting imports of traits declared inside fn bodies)
Move parse error recovery for expression operators "out of line" & refactor in the area #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area)
[rustdoc] Correctly handle intra-doc links on inlined same item with different names #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names)
Add useful APIs to Unique(Arc|Rc) #162733 (Add useful APIs to Unique(Arc|Rc))
Refactor LivenessResults into LivenessComputation, without typeck #162913 (Refactor LivenessResults into LivenessComputation, without typeck)
Remove applying inline attributes at the callsite #162924 (Remove applying inline attributes at the callsite)
Use spawned SBDebugger instance #162940 (Use spawned SBDebugger instance)
More AST lowering cleanups #162950 (More AST lowering cleanups)
Update browser-ui-test version to 0.25.2 #162964 (Update browser-ui-test version to 0.25.2)
mark f128 as reliable on powerpc64 with +vsx #162979 (mark f128 as reliable on powerpc64 with +vsx)
Add performance notes for the floating-point round method #161743 (Add performance notes for the floating-point round method)
yeet AliasConstKind::opt_def_id #162797 (yeet AliasConstKind::opt_def_id)
Ping T-libs-ping instead of T-libs-fcp for backports #162836 (Ping T-libs-ping instead of T-libs-fcp for backports)
Adjust bug!/span_bug! emission #162873 (Adjust bug!/span_bug! emission)
Add missing #[repr(C)] in UI, codegen and assembly tests #162956 (Add missing #[repr(C)] in UI, codegen and assembly tests)
rustc-dev-guide subtree update #162981 (rustc-dev-guide subtree update)

- identify issues by label and title - reuse an existing issue if it already exists - use a bash script around `gh` so we don't add unvetted dependencies - add tests for the bash script using a fake `gh` mock

…x-lowering-link-and-thir-typo fix: typo in thir.md

open issues when scheduled linkcheck fails

spelling

adjust docs to latest offload usage

adjust docs to latest offload install

This updates the rust-version file to 4b6d04e.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@4b6d04e Filtered ref: rust-lang/rustc-dev-guide@9f03875 Upstream diff: rust-lang/rust@32d94cc...4b6d04e This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

fix generic offload usage

…ntra doc link

Avoid calling `type_is_copy_modulo_regions` if not necessary.

Both will be used by the amdgpu target to implement the `gpu-kernel` ABI. `address_space` specifies the address space of an indirect argument. `AmdgpuKernelArg` translates to LLVM’s byref, which is similar to on_stack/byval, however, there is no extra copy made, the pointer may not point to the stack but can point to some other address space, and the passed argument should not be modified. byval and byref are mutually exclusive, so change on_stack to an enum with the new states, Pointer (none), OnStack and AmdgpuKernelArg.

This updates the rust-version file to c999cef.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@c999cef Filtered ref: rust-lang/rustc-dev-guide@7c052fc Upstream diff: rust-lang/rust@4b6d04e...c999cef This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

@folkertdev

…kertdev Add missing `#[repr(C)]` in UI, codegen and assembly tests There are quite a few tests which omit the `#[repr(C)]` on structs that are then used in non-Rustic ABIs. I've gone through the tests in `ui/abi`, `ui/ffi`, `codegen-llvm` and `assembly-llvm` and added `#[repr(C)]` where it was missing. I also converted `#[allow(improper_ctypes{,_definitions})]` to `#[expect(improper_ctypes{,_definitions})]` where possible, and removed it where the lint no longer triggers. I haven't done it in this PR, but I think it's worth making codegen and assembly tests deny warnings by default. With UI tests `improper_ctypes{,_definitions}` has to be either allowed or will show up in the output, meaning it should be fairly obvious to reviewers, but with codegen and assembly tests warnings just get ignored if the test passes. Fixes rust-lang#53858 r? @folkertdev cc @RalfJung

@ghost

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@9bf6185. Created using https://github.com/rust-lang/josh-sync. r? @ghost

JonathanBrouwer · 2026-09-19T06:02:18Z

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-gnu-llvm-21-3,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu

rust-bors · 2026-09-19T06:02:21Z

📌 Commit 65cb54e has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 20 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu

rust-log-analyzer · 2026-09-19T06:33:19Z

The job test-x86_64-gnu-llvm-21-3 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

To only update this specific test, also pass `--test-args abi/c-zst.rs`

error in revision `sparc-linux`: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/bin/rustc" "/checkout/tests/ui/abi/c-zst.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1" "--cfg" "sparc_linux" "--check-cfg" "cfg(test,FALSE,aarch64_darwin,x86_64_linux,powerpc_linux,s390x_linux,sparc_none,sparc_linux,sparc64_linux,x86_64_pc_windows_gnu)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/c-zst.sparc-linux" "-Znext-solver=coherence" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--target" "sparc-unknown-linux-gnu" "--extern" "minicore=/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/c-zst.sparc-linux/libminicore.rlib"
stdout: none
--- stderr -------------------------------
error: fn_abi_of(pass_zst) = FnAbi {
           args: [
               ArgAbi {
                   layout: TyAndLayout {
                       ty: (),
                       layout: Layout {
---
                       },
                   },
                   mode: Indirect {
                       attrs: ArgAttributes {
                           regular: CapturesAddress | NoAlias | NonNull | NoUndef | NoFree,
                           arg_ext: None,
                           pointee_size: Size(0 bytes),
                           pointee_align: Some(
                               Align(1 bytes),
                           ),
                       },
                       meta_attrs: None,
                       address_space: None,
                       mode: Pointer,
---
           can_unwind: false,
       }
  --> /checkout/tests/ui/abi/c-zst.rs:67:1
   |
LL | extern "C" fn pass_zst(_: ()) {} //~ ERROR: fn_abi
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 1 previous error
------------------------------------------

---
To only update this specific test, also pass `--test-args abi/c-zst.rs`

error in revision `sparc-none`: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/bin/rustc" "/checkout/tests/ui/abi/c-zst.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1" "--cfg" "sparc_none" "--check-cfg" "cfg(test,FALSE,aarch64_darwin,x86_64_linux,powerpc_linux,s390x_linux,sparc_none,sparc_linux,sparc64_linux,x86_64_pc_windows_gnu)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/c-zst.sparc-none" "-Znext-solver=coherence" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--target" "sparc-unknown-none-elf" "--extern" "minicore=/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/c-zst.sparc-none/libminicore.rlib"
stdout: none
--- stderr -------------------------------
error: fn_abi_of(pass_zst) = FnAbi {
           args: [
               ArgAbi {
                   layout: TyAndLayout {
                       ty: (),
                       layout: Layout {
---
                       },
                   },
                   mode: Indirect {
                       attrs: ArgAttributes {
                           regular: CapturesAddress | NoAlias | NonNull | NoUndef | NoFree,
                           arg_ext: None,
                           pointee_size: Size(0 bytes),
                           pointee_align: Some(
                               Align(1 bytes),
                           ),
                       },
                       meta_attrs: None,
                       address_space: None,
                       mode: Pointer,
---
           can_unwind: false,
       }
  --> /checkout/tests/ui/abi/c-zst.rs:67:1
   |
LL | extern "C" fn pass_zst(_: ()) {} //~ ERROR: fn_abi
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 1 previous error
------------------------------------------

rust-log-analyzer · 2026-09-19T06:39:27Z

The job test-x86_64-gnu-llvm-21 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

To only update this specific test, also pass `--test-args abi/c-zst.rs`

error in revision `sparc-linux`: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/abi/c-zst.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--cfg" "sparc_linux" "--check-cfg" "cfg(test,FALSE,aarch64_darwin,x86_64_linux,powerpc_linux,s390x_linux,sparc_none,sparc_linux,sparc64_linux,x86_64_pc_windows_gnu)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/c-zst.sparc-linux" "-Znext-solver=coherence" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=x86_64-linux-gnu-gcc" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--target" "sparc-unknown-linux-gnu" "--extern" "minicore=/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/c-zst.sparc-linux/libminicore.rlib"
stdout: none
--- stderr -------------------------------
error: fn_abi_of(pass_zst) = FnAbi {
           args: [
               ArgAbi {
                   layout: TyAndLayout {
                       ty: (),
                       layout: Layout {
---
                       },
                   },
                   mode: Indirect {
                       attrs: ArgAttributes {
                           regular: CapturesAddress | NoAlias | NonNull | NoUndef | NoFree,
                           arg_ext: None,
                           pointee_size: Size(0 bytes),
                           pointee_align: Some(
                               Align(1 bytes),
                           ),
                       },
                       meta_attrs: None,
                       address_space: None,
                       mode: Pointer,
---
           can_unwind: false,
       }
  --> /checkout/tests/ui/abi/c-zst.rs:67:1
   |
LL | extern "C" fn pass_zst(_: ()) {} //~ ERROR: fn_abi
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 1 previous error
------------------------------------------

---
To only update this specific test, also pass `--test-args abi/c-zst.rs`

error in revision `sparc-none`: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/abi/c-zst.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--cfg" "sparc_none" "--check-cfg" "cfg(test,FALSE,aarch64_darwin,x86_64_linux,powerpc_linux,s390x_linux,sparc_none,sparc_linux,sparc64_linux,x86_64_pc_windows_gnu)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/c-zst.sparc-none" "-Znext-solver=coherence" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=x86_64-linux-gnu-gcc" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--target" "sparc-unknown-none-elf" "--extern" "minicore=/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/abi/c-zst.sparc-none/libminicore.rlib"
stdout: none
--- stderr -------------------------------
error: fn_abi_of(pass_zst) = FnAbi {
           args: [
               ArgAbi {
                   layout: TyAndLayout {
                       ty: (),
                       layout: Layout {
---
                       },
                   },
                   mode: Indirect {
                       attrs: ArgAttributes {
                           regular: CapturesAddress | NoAlias | NonNull | NoUndef | NoFree,
                           arg_ext: None,
                           pointee_size: Size(0 bytes),
                           pointee_align: Some(
                               Align(1 bytes),
                           ),
                       },
                       meta_attrs: None,
                       address_space: None,
                       mode: Pointer,
---
           can_unwind: false,
       }
  --> /checkout/tests/ui/abi/c-zst.rs:67:1
   |
LL | extern "C" fn pass_zst(_: ()) {} //~ ERROR: fn_abi
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 1 previous error
------------------------------------------

rust-bors · 2026-09-19T06:44:06Z

PR #162177, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

rust-bors · 2026-09-19T08:42:30Z

💔 Test for be41ac7 failed: CI. Failed jobs:

try - test-aarch64-apple-1 (web logs, enhanced plaintext logs)
try - test-armhf-gnu (web logs, enhanced plaintext logs)
try - test-i686-msvc (web logs, enhanced plaintext logs)
try - test-various (web logs, enhanced plaintext logs)
try - test-x86_64-gnu-llvm-21-3 (web logs, enhanced plaintext logs)
(and 2 other jobs)

joonas-001 and others added 30 commits August 25, 2026 19:49

Add performance notes for the floating-point round method

746c872

open issues when scheduled linkcheck fails

c447e2e

- identify issues by label and title - reuse an existing issue if it already exists - use a bash script around `gh` so we don't add unvetted dependencies - add tests for the bash script using a fake `gh` mock

Add regression test for importing block-scoped traits

9565ced

Avoid suggesting imports of traits declared inside bodies

c9e2b67

fix: typo in thir.md

c18476f

Merge pull request rust-lang/rustc-dev-guide#3005 from 000wahab000/fi…

40dc2a3

…x-lowering-link-and-thir-typo fix: typo in thir.md

address review comments

7878498

Merge pull request rust-lang#2993 from jyn514/track-broken-links

b1c6599

open issues when scheduled linkcheck fails

spelling

4aee1dc

Merge pull request rust-lang#3011 from supercooltest2024/patch-1

68ddb1e

spelling

Add the alternatives parts in Cache::paths

fe47365

adjust docs to latest offload usage

3ddd7e4

Merge pull request rust-lang#3012 from rust-lang/offload-usage-update

e5d963f

adjust docs to latest offload usage

adjust docs to latest offload install

10e1f7e

Merge pull request rust-lang#3013 from rust-lang/offload-install-update

301f62f

adjust docs to latest offload install

Add useful APIs to Unique(Arc|Rc)

1629bcd

Prepare for merging from rust-lang/rust

7e37472

This updates the rust-version file to 4b6d04e.

Merge pull request rust-lang#3014 from rust-lang/rustc-pull

bfbf4b1

Rustc pull update

fix generic offload usage

a74f1e7

Merge pull request rust-lang#3015 from rust-lang/offload-usage-update2

b88268a

fix generic offload usage

Ping T-libs-ping instead of T-libs-fcp for backports

a1864bd

Fix formatting, and make wording consistent

f68cc95

Provide the "preferred name" when generating href and title for i…

ba736a0

…ntra doc link

Add regression test for inlined same item with different names

cd6287f

Mini optimization in restrict_precision_for_drop_types

005aa45

Avoid calling `type_is_copy_modulo_regions` if not necessary.

Prepare for merging from rust-lang/rust

fff83c5

This updates the rust-version file to c999cef.

Merge pull request rust-lang#3019 from rust-lang/rustc-pull

093dd66

Rustc pull update

JonathanBrouwer added 2 commits September 19, 2026 08:02

Rollup merge of rust-lang#162981 - tshepang:rdg-sync, r=tshepang

65cb54e

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@9bf6185. Created using https://github.com/rust-lang/josh-sync. r? @ghost

rust-bors Bot added the rollup A PR which is a rollup label Sep 19, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Sep 19, 2026

Properly implement the gpu-kernel ABI for amdgpu #162177

Open

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2026

JonathanBrouwer closed this Sep 19, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 19, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 19, 2026

Navigation Menu

Uh oh!

Rollup of 20 pull requests - #163000

Rollup of 20 pull requests#163000
JonathanBrouwer wants to merge 113 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-6WA6MxA

JonathanBrouwer commented Sep 19, 2026

Uh oh!

JonathanBrouwer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 19, 2026

Uh oh!

rust-log-analyzer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Conversation

JonathanBrouwer commented Sep 19, 2026

Uh oh!

JonathanBrouwer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 19, 2026

Uh oh!

rust-log-analyzer commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants