fix: Recover from MIR field projections on slices#22756
Closed
northaxosky wants to merge 1 commit into
Closed
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MIR borrow checking can encounter a
Fieldprojection whose base type is a slice while computing diagnostics.field_tytreated that as an invariant violation and panicked withcan't project out of [T].A
Fieldprojection contains no index with which to select an array or slice element, so it cannot produce a meaningful field type. Recover with the error type for array and slice bases, while retaining the invariant check for other unexpected types.The regression test directly exercises
PlaceTy([bool]).projection_ty(Field(0)). It panics before this change and returns the error type afterward.Test:
cargo test -p hir-ty