Skip to content

Add object_id to protected methods #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FionaDL wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add object_id to protected methods #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/ostruct.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,8 @@ def new_ostruct_member!(name) # :nodoc:
private def is_method_protected!(name) # :nodoc:
if !respond_to?(name, true)
false
elsif name.match?(/^object_id$/)

@gemmaro gemmaro Sep 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String comparison should be less expensive than Regexp:

Suggested change
elsif name.match?(/^object_id$/)
elsif 'object_id' == name

true
elsif name.match?(/!$/)
true
else
Expand Down