Add object_id to protected methods - #92
Open
FionaDL wants to merge 1 commit into
Open
Conversation
FionaDL
force-pushed
the
object-id-warning
branch
from
December 15, 2025 19:33
5f96f03 to
ec6d601
Compare
gemmaro
reviewed
Sep 4, 2026
gemmaro
left a comment
gemmaro
left a comment
There was a problem hiding this comment.
Adding test cases for this change might be useful, since there are assertions for protected methods, such as bang methods (e.g. in test_override_subclass).
| private def is_method_protected!(name) # :nodoc: | ||
| if !respond_to?(name, true) | ||
| false | ||
| elsif name.match?(/^object_id$/) |
There was a problem hiding this comment.
String comparison should be less expensive than Regexp:
Suggested change
| elsif name.match?(/^object_id$/) | |
| elsif 'object_id' == name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #75.
While working on a project with ruby 3.4.7 we were continuously seeing the following warning:
warning: redefining 'object_id' may cause serious problemsThis PR adds
object_idto the check for protected methods.