fix(feedback): align SDK and CLI with legacy wire contract - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24.
Preserves the existing SDK/CLI argument and return shapes while sending trace_id and integer value. Scores must be integers from -10 through 10 without rescaling; invalid scores and unsupported nonempty comments fail before dispatch. Empty/null/omitted comments are omitted. CLI acknowledgement no longer claims durable recording.
The unmodified published CLI 0.5.3 was reproduced against both acceptance profiles before implementation: streaming completed, then feedback returned HTTP 400 for missing trace_id. Baseline wire evidence is retained in the programme lab.
Validation: 41 of 42 new SDK regression tests failed against old source. Final forced builds and lint pass across the monorepo; 126 SDK and 63 CLI tests pass without cached results. Independent security review approved exact head c78d5e5. The unchanged MCP helper is outside this SDK/CLI patch.
Package publication and installed-package acceptance remain tracked by routeplane-core/docs#563 and routeplane-core/routeplane-ce#66. No workflow, dependency or runtime transport changes.