build(vendor): gate test interfaces to tests and doctests - #625
Draft
esteve wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
esteve
force-pushed
the
vendored-messages-only-for-tests
branch
2 times, most recently
from
April 13, 2026 21:09
666bf77 to
7ec5352
Compare
esteve
marked this pull request as draft
April 13, 2026 21:35
Collaborator
Author
|
Back to draft to figure out a better solution. |
esteve
force-pushed
the
vendored-messages-only-for-tests
branch
5 times, most recently
from
April 15, 2026 15:52
59f43d6 to
d58d085
Compare
esteve
force-pushed
the
vendored-messages-only-for-tests
branch
from
May 16, 2026 17:18
d58d085 to
373a352
Compare
esteve
force-pushed
the
vendored-messages-only-for-tests
branch
3 times, most recently
from
May 17, 2026 17:00
e6bf879 to
fc89c9f
Compare
esteve
force-pushed
the
vendored-messages-only-for-tests
branch
from
June 14, 2026 13:03
fc89c9f to
04f0e53
Compare
Signed-off-by: Esteve Fernandez <esteve@apache.org>
esteve
force-pushed
the
vendored-messages-only-for-tests
branch
from
June 14, 2026 15:29
04f0e53 to
8961be5
Compare
Signed-off-by: Esteve Fernandez <esteve@apache.org>
esteve
force-pushed
the
vendored-messages-only-for-tests
branch
from
June 14, 2026 15:35
8961be5 to
053a9ad
Compare
Collaborator
|
Any chance someone can provide me with a minimal workspace where this occurs? I did this mkdir -p ~/test_ws/src && cd ~/test_ws/
ros2 pkg create --build-type ament_cargo foobin --destination-directory src
colcon build
ldd build/foobin/debug/foobin | grep -i -E "test_msgs|example_interfaces|test_interface_files"But there is no linkage to test_msgs or any of the other aforementioned packages. I also then tried to have rclrs in the workspace as a cargo path dependency for git clone git@github.com:ros2-rust/ros2_rust.git src/ros2_rust
rm -rf build/ log/ install/ .cargo/
sed -i 's|rclrs = "\*"|rclrs = { path = "../ros2_rust/rclrs" }|' src/foobin/Cargo.toml
colcon build
ldd build/foobin/debug/foobin | grep -i -E "test_msgs|example_interfaces|test_interface_files"And finally I tried making sure rm -rf build/ log/ install/ .cargo/
# Go back to the default "*" import from the package template
sed -i 's|rclrs = { path = "../ros2_rust/rclrs" }|rclrs = "*"|' src/foobin/Cargo.toml
sed -i '/<\/license>/a\ <depend>rclrs</depend>' src/foobin/package.xml
colcon build
ldd build/foobin/debug/foobin | grep -i -E "test_msgs|example_interfaces|test_interface_files"But still, I am not seeing any linkage to these debug packages. Maybe I'm missing something but for now I'm not seeing the issue |
maspe36
reviewed
Jun 26, 2026
| pub use vendor::*; | ||
| pub use vendor::*; | ||
| } else { | ||
| pub use ros_env::{ |
Collaborator
There was a problem hiding this comment.
This means that these symbols now live under rclrs:: instead of ros_env::, that goes against the intent of the ros_env crate as the source for all ROS 2 message code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids including the
test_msgsandexample_interfacespackages when not buildingrclrsfor testing.