This repository was archived by the owner on Aug 25, 2026. It is now read-only.
feat: sync common pages across distributions - #36
Merged
Conversation
Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
AJedancov
marked this pull request as ready for review
August 8, 2026 12:44
This was referenced Aug 8, 2026
Member
|
I assume a similar thing will be applied to lyrical LGTM, just questions on TODOs if they're meant to stay or not |
SteveMacenski
approved these changes
Aug 10, 2026
Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
AJedancov
force-pushed
the
feat/share-pages--with-home-page
branch
from
August 11, 2026 13:00
bf146a1 to
13912f4
Compare
Collaborator
Author
Sure, I'll make the same changes there. I've also removed the homepage from the sync, as mentioned in the main ticket. |
Collaborator
Author
|
I see the main concept is approved. Do you mind if I merge this now, even if further discussions/changes will follow? This would simplify the testing of such cross-branch changes. |
SteveMacenski
approved these changes
Aug 11, 2026
AJedancov
added a commit
that referenced
this pull request
Aug 12, 2026
* feat: implement sharing of common pages across distributions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * feat: implement synchronization for home page Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * chore: revert homepage synchronisation Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
AJedancov
added a commit
that referenced
this pull request
Aug 13, 2026
* feat: implement sharing of common pages across distributions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * feat: implement synchronization for home page Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * chore: revert homepage synchronisation Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
AJedancov
added a commit
that referenced
this pull request
Aug 14, 2026
* feat: implement sharing of common pages across distributions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * feat: implement synchronization for home page Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * chore: revert homepage synchronisation Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
AJedancov
added a commit
that referenced
this pull request
Aug 15, 2026
* feat: implement sharing of common pages across distributions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * feat: implement synchronization for home page Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * chore: revert homepage synchronisation Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
AJedancov
added a commit
that referenced
this pull request
Aug 17, 2026
* feat: implement sharing of common pages across distributions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * feat: implement synchronization for home page Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * chore: revert homepage synchronisation Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
AJedancov
added a commit
that referenced
this pull request
Aug 18, 2026
* feat: implement sharing of common pages across distributions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * feat: implement synchronization for home page Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * chore: revert homepage synchronisation Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
AJedancov
added a commit
that referenced
this pull request
Aug 18, 2026
* feat: implement sharing of common pages across distributions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * feat: implement synchronization for home page Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * chore: revert homepage synchronisation Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
AJedancov
added a commit
that referenced
this pull request
Aug 19, 2026
* feat: implement sharing of common pages across distributions Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * feat: implement synchronization for home page Signed-off-by: AJedancov <andrei.jedancov@gmail.com> * chore: revert homepage synchronisation Signed-off-by: AJedancov <andrei.jedancov@gmail.com> --------- Signed-off-by: AJedancov <andrei.jedancov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
A commit for Jazzy that automatically syncs common pages from the Rolling branch.
To do this, I used the cloning approach that was implemented previously. I've added an extra parameter
destination_dirto specify exactly where to clone the files:Common subpages, together with their assets, are cloned to
docs/shared. Since they're in the main/docsdirectory, they're automatically included in the documentation build.As this feature will be used in non-rolling branches, some steps must be repeated each time a new version is released:
docs/shareddirectory and add a README file to it, so that there is at least one file and git can track the empty directory.I think we can combine steps 3 and 4 and move them to the Rolling branch to simplify the process a little. I've added #37 with these steps for the new documentation release process.
I've also slightly changed the structure in Rolling, now the home index and its images are in a separate directory, so that it's easier to reference it when setting up the macro.
Note1: I intentionally didn't use the
.nav.ymlfile in the newhomedirectory. As this plugin doesn't handle relative links correctly (e.g. "../getting_started/index.md"), and these are needed to create the first two levels of the navigation tree.Note2: Fetching all the graphic materials from GitHub, particularly the videos for the homepage, increases the time taken for the first build. This is unlikely to be a problem for users, as it only happens once and is then used as a cache, but this will also affect the execution time of each CI pipeline.