Skip to content

feat(auth): local auth - #938

Open
JosephKav wants to merge 12 commits into
masterfrom
feat/auth
Open

feat(auth): local auth#938
JosephKav wants to merge 12 commits into
masterfrom
feat/auth

Conversation

@JosephKav

Copy link
Copy Markdown
Collaborator

No description provided.

@JosephKav JosephKav added enhancement New feature or request javascript Pull requests that update Javascript code go Pull requests that update Go code labels Jul 23, 2026
Comment thread web/api/v1/http-api-auth.go Fixed
Comment thread web/api/v1/http-api-auth.go Fixed
@JosephKav JosephKav mentioned this pull request Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.84448% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.65%. Comparing base (326bc34) to head (89b6dfb).

Files with missing lines Patch % Lines
auth/store/test/faultdb.go 97.65% 1 Missing and 1 partial ⚠️
auth/provider/local/local.go 98.12% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
- Coverage   99.71%   99.65%   -0.06%     
==========================================
  Files         204      226      +22     
  Lines       13027    15856    +2829     
==========================================
+ Hits        12989    15799    +2810     
- Misses         33       45      +12     
- Partials        5       12       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread cmd/argus/auth.go Fixed
@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown

✅ Playwright Test Results

Count
✅ Passed 438
❌ Failed 0
🔄 Flaky 0
⏭️ Skipped 4

Duration: 919.1s

View screenshots & full report

Comment thread cmd/argus/auth.go Dismissed
@JosephKav
JosephKav force-pushed the feat/auth branch 2 times, most recently from 55f6993 to 265ba37 Compare August 25, 2026 14:57
@JosephKav
JosephKav marked this pull request as ready for review August 25, 2026 15:55
Untrusted peers keep their socket address, so a forwarded header cannot
be spoofed to bypass an IP-based decision.
Resolved from X-Forwarded-Host/X-Forwarded-Proto, and only for peers
listed in settings.web.trusted_proxies. Adds Sec-Fetch-Site as a
browser-set signal a page cannot forge, and parses trusted_proxies from
its ARGUS_ environment variable.
The UI takes its path prefix from <base href> rather than guessing it
from known app paths. Also folds the RBAC guards onto a shared authGuard
helper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update Go code javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants