refactor: Err* error naming, test hygiene and build tidy-up - #964
Merged
Conversation
- Write configs to one process-lifetime temp dir (created in TestMain), so
late debounced saves always find it and the save-drain sleeps can go.
- Sweep stray temp dirs at startup, since a killed/timed-out run can't run
the end-of-run cleanup.
- Resolve the GitHub token from ${GITHUB_TOKEN} at read time where it's used
(api, cmd) and use an inert placeholder where it isn't (config, web), so no
real token is persisted to disk.
✅ Playwright Test Results
Duration: 891.7s |
JosephKav
marked this pull request as ready for review
August 5, 2026 21:31
Argus-Bot
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out the housekeeping from the Auth PR #938.
Changes
refactor- rename error types to the Go-idiomaticErr*form:FieldError->ErrFieldKeyFieldError->ErrKeyFieldInvalidTypeError->ErrInvalidTypefix(api)- takeConfig.OrderMu.RLock()around the duplicate ID/Name check inhttpServiceEdit, which readConfig.Serviceunguarded while tracking goroutines could be mutating it.chore(makefile)-web-installnow usesnpm ciinstead ofnpm install.chore(go)- droptest.Ptrin favour of Go 1.26'snew(expr).docs- add see-links from overridable vars to their override points.Tests
time.Sleeps replaced with a shared config dir, removing the main source of slowness/flake in the api/cmd/config/web suites.DockerTagCheckruns skip rather than fail when the registry rate-limits.