Conversation
meta-cla
Bot
added
the
CLA Signed
|
@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122152628. |
cortinico
approved these changes
Sep 28, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
Summary: Pull Request resolved: #58720 Internal and OSS Flow disagreed on DOM builtins, so suppressions removed in #1965 were unused in OSS but needed internally. - .flowconfig: builtin_lib=flowlib-with-lib-dom-d-ts - Delete copied DOM libdefs flow-typed/environment/{bom,dom,cssom,serviceworkers,streams}.js - flow-typed/environment/node.js: use globalThis.Blob; drop an unused suppression - Restore suppressions needed under lib.dom.d.ts Console (index-test.js, resolver-test.js, logToConsole.js) and drop ones now unused - HMRClient-test.js: mock WebSocket via jest.spyOn(global, 'WebSocket', 'get') instead of writing the readonly global Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122152628
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
export-D122152628
branch
from
September 28, 2026 15:11
059cf64 to
ded5c61
Compare
Summary: Internal and OSS Flow disagreed on DOM builtins, so suppressions removed in #1965 were unused in OSS but needed internally. - .flowconfig: builtin_lib=flowlib-with-lib-dom-d-ts - Delete copied DOM libdefs flow-typed/environment/{bom,dom,cssom,serviceworkers,streams}.js - flow-typed/environment/node.js: use globalThis.Blob; drop an unused suppression - Restore suppressions needed under lib.dom.d.ts Console (index-test.js, resolver-test.js, logToConsole.js) and drop ones now unused - HMRClient-test.js: mock WebSocket via jest.spyOn(global, 'WebSocket', 'get') instead of writing the readonly global Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122152628
meta-codesync
Bot
force-pushed
the
export-D122152628
branch
from
September 28, 2026 16:39
ded5c61 to
e1d6707
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Internal and OSS Flow disagreed on DOM builtins, so suppressions removed in #1965 were unused in OSS but needed internally.
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D122152628