Skip to content

Commit ded5c61

Browse files
vzaidmanmeta-codesync[bot]
authored andcommitted
Align OSS Flow config with lib.dom.d.ts (#1989) (#58720)
Summary: Pull Request resolved: #58720 Internal and OSS Flow disagreed on DOM builtins, so suppressions removed in #1965 were unused in OSS but needed internally. - .flowconfig: builtin_lib=flowlib-with-lib-dom-d-ts - Delete copied DOM libdefs flow-typed/environment/{bom,dom,cssom,serviceworkers,streams}.js - flow-typed/environment/node.js: use globalThis.Blob; drop an unused suppression - Restore suppressions needed under lib.dom.d.ts Console (index-test.js, resolver-test.js, logToConsole.js) and drop ones now unused - HMRClient-test.js: mock WebSocket via jest.spyOn(global, 'WebSocket', 'get') instead of writing the readonly global Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122152628
1 parent 7ca1b42 commit ded5c61

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

‎flow-typed/environment/node.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ declare module 'buffer' {
213213

214214
declare function isAscii(input: Buffer | ArrayBuffer | $TypedArray): boolean;
215215

216-
declare function resolveObjectURL(id: string): Blob | void;
216+
declare function resolveObjectURL(id: string): globalThis.Blob | void;
217217

218218
declare var Buffer: Node$Buffer;
219219
declare var Blob: typeof globalThis.Blob;
@@ -3756,7 +3756,6 @@ declare class stream$Duplex extends stream$Readable mixins stream$Writable {
37563756
// with Readable's, which Flow doesn't like.
37573757
// See https://nodejs.org/api/stream.html#stream_class_stream_duplex_1
37583758

3759-
// $FlowFixMe[incompatible-exact] See above
37603759
// $FlowFixMe[incompatible-type] See above
37613760
static fromWeb(
37623761
pair: Readonly<{

0 commit comments

Comments
 (0)