Make select graphics and debug implementation headers private - #58714
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
Summary: Changelog: [Internal] Mark `rounding.h` and `debugStringConvertibleUtils.h` as private, and mark `RCTPlatformColorUtils.h` (iOS and macOS) as for-frameworks. Stop re-exporting them (and `configurePlatformColorCacheInvalidationHook.h`) from the `React/Graphics.h` and `React/RendererDebug.h` umbrellas. These are implementation helpers, not public API. `RCTPlatformColorUtils.h` stays reachable by direct include because for-frameworks inline helpers such as `RCTUIColorFromSharedColor` call into it. Reviewed By: cipolleschi Differential Revision: D122131841
j-piasecki
force-pushed
the
export-D122131841
branch
from
September 29, 2026 07:19
010af78 to
eda8311
Compare
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122131841. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…58714) Summary: Changelog: [Internal] Mark `rounding.h` and `debugStringConvertibleUtils.h` as private, and mark `RCTPlatformColorUtils.h` (iOS and macOS) as for-frameworks. Stop re-exporting them (and `configurePlatformColorCacheInvalidationHook.h`) from the `React/Graphics.h` and `React/RendererDebug.h` umbrellas. These are implementation helpers, not public API. `RCTPlatformColorUtils.h` stays reachable by direct include because for-frameworks inline helpers such as `RCTUIColorFromSharedColor` call into it. Reviewed By: cipolleschi Differential Revision: D122131841
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…58714) Summary: Changelog: [Internal] Mark `rounding.h` and `debugStringConvertibleUtils.h` as private, and mark `RCTPlatformColorUtils.h` (iOS and macOS) as for-frameworks. Stop re-exporting them (and `configurePlatformColorCacheInvalidationHook.h`) from the `React/Graphics.h` and `React/RendererDebug.h` umbrellas. These are implementation helpers, not public API. `RCTPlatformColorUtils.h` stays reachable by direct include because for-frameworks inline helpers such as `RCTUIColorFromSharedColor` call into it. Reviewed By: cipolleschi Differential Revision: D122131841
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…58714) Summary: Changelog: [Internal] Mark `rounding.h` and `debugStringConvertibleUtils.h` as private, and mark `RCTPlatformColorUtils.h` (iOS and macOS) as for-frameworks. Stop re-exporting them (and `configurePlatformColorCacheInvalidationHook.h`) from the `React/Graphics.h` and `React/RendererDebug.h` umbrellas. These are implementation helpers, not public API. `RCTPlatformColorUtils.h` stays reachable by direct include because for-frameworks inline helpers such as `RCTUIColorFromSharedColor` call into it. Reviewed By: cipolleschi Differential Revision: D122131841
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…58714) Summary: Changelog: [Internal] Mark `rounding.h` and `debugStringConvertibleUtils.h` as private, and mark `RCTPlatformColorUtils.h` (iOS and macOS) as for-frameworks. Stop re-exporting them (and `configurePlatformColorCacheInvalidationHook.h`) from the `React/Graphics.h` and `React/RendererDebug.h` umbrellas. These are implementation helpers, not public API. `RCTPlatformColorUtils.h` stays reachable by direct include because for-frameworks inline helpers such as `RCTUIColorFromSharedColor` call into it. Reviewed By: cipolleschi Differential Revision: D122131841
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…58714) Summary: Changelog: [Internal] Mark `rounding.h` and `debugStringConvertibleUtils.h` as private, and mark `RCTPlatformColorUtils.h` (iOS and macOS) as for-frameworks. Stop re-exporting them (and `configurePlatformColorCacheInvalidationHook.h`) from the `React/Graphics.h` and `React/RendererDebug.h` umbrellas. These are implementation helpers, not public API. `RCTPlatformColorUtils.h` stays reachable by direct include because for-frameworks inline helpers such as `RCTUIColorFromSharedColor` call into it. Reviewed By: cipolleschi Differential Revision: D122131841
|
This pull request has been merged in 1c5a032. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Mark
rounding.handdebugStringConvertibleUtils.has private, and markRCTPlatformColorUtils.h(iOS and macOS) as for-frameworks. Stop re-exporting them (andconfigurePlatformColorCacheInvalidationHook.h) from theReact/Graphics.handReact/RendererDebug.humbrellas. These are implementation helpers, not public API.RCTPlatformColorUtils.hstays reachable by direct include because for-frameworks inline helpers such asRCTUIColorFromSharedColorcall into it.Reviewed By: cipolleschi
Differential Revision: D122131841