Skip to content

Commit eda8311

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Make select graphics and debug implementation headers private
Summary: Changelog: [Internal] Mark `rounding.h` and `debugStringConvertibleUtils.h` as private, and mark `RCTPlatformColorUtils.h` (iOS and macOS) as for-frameworks. Stop re-exporting them (and `configurePlatformColorCacheInvalidationHook.h`) from the `React/Graphics.h` and `React/RendererDebug.h` umbrellas. These are implementation helpers, not public API. `RCTPlatformColorUtils.h` stays reachable by direct include because for-frameworks inline helpers such as `RCTUIColorFromSharedColor` call into it. Reviewed By: cipolleschi Differential Revision: D122131841
1 parent 9b131e4 commit eda8311

5 files changed

Lines changed: 3 additions & 13 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/debug/React/RendererDebug.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232

3333
#include <react/renderer/debug/DebugStringConvertible.h>
3434
#include <react/renderer/debug/DebugStringConvertibleItem.h>
35-
#include <react/renderer/debug/debugStringConvertibleUtils.h>
3635
#include <react/renderer/debug/flags.h>
3736

3837
#undef RN_UMBRELLA_CONTEXT

‎packages/react-native/ReactCommon/react/renderer/debug/debugStringConvertibleUtils.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <memory>
1313
#include <optional>

‎packages/react-native/ReactCommon/react/renderer/graphics/React/Graphics.h‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,6 @@
5353
#include <react/renderer/graphics/ValueUnit.h>
5454
#include <react/renderer/graphics/Vector.h>
5555
#include <react/renderer/graphics/fromRawValueShared.h>
56-
#include <react/renderer/graphics/rounding.h>
57-
58-
#ifdef ANDROID
59-
#include <react/renderer/graphics/configurePlatformColorCacheInvalidationHook.h>
60-
#endif
61-
62-
#if defined(__APPLE__) && defined(__OBJC__)
63-
#include <react/renderer/graphics/RCTPlatformColorUtils.h>
64-
#endif
6556

6657
#undef RN_UMBRELLA_CONTEXT
6758
#pragma pop_macro("RN_UMBRELLA_CONTEXT")

‎packages/react-native/ReactCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/RCTPlatformColorUtils.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#import <UIKit/UIKit.h>
1313
#import <vector>

‎packages/react-native/ReactCommon/react/renderer/graphics/rounding.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <react/renderer/graphics/Float.h>
1313

0 commit comments

Comments
 (0)