Skip to content

refactor: remove unnecessary important declarations - #134

Merged
rdlabo merged 1 commit into
refactor/prefer-css-custom-propertiesfrom
refactor/remove-unnecessary-important
Aug 31, 2026
Merged

refactor: remove unnecessary important declarations#134
rdlabo merged 1 commit into
refactor/prefer-css-custom-propertiesfrom
refactor/remove-unnecessary-important

Conversation

@rdlabo

@rdlabo rdlabo commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove normal-cascade important declarations where selector specificity is already sufficient
  • use a narrowly scoped collapsing-header selector where additional specificity is required
  • reorder range mixins so the intended transform wins without important
  • reduce searchbar important usage from three broad declarations to one centered-placeholder state required to override Ionic inline padding

Compatibility

  • this PR is intentionally stacked on refactor: prefer CSS custom properties over Shadow Parts #133 so it contains only important cleanup
  • the resulting combined source is identical to the previously reviewed and Mac-verified implementation
  • no demo-specific selectors or fixture assumptions
  • manager and independent acceptance reviews completed with no blocking findings

Validation

  • npm run build
  • Prettier check for src
  • git diff --check
  • affected Mac Chrome light/dark screenshots matched the before-change baseline
  • verified collapsing-header transition and pressed single/dual range computed styles

Linux Playwright snapshots were not modified.

@github-actions

Copy link
Copy Markdown
Contributor

Playwright test results

passed  90 passed

Details

stats  90 tests across 2 suites
duration  1 minute, 53 seconds
commit  130ac69
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-134/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@rdlabo
rdlabo merged commit 20af967 into refactor/prefer-css-custom-properties Aug 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant